From: Gleb Natapov <gleb@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org, joerg.roedel@amd.com
Subject: Re: [PATCH 6/6] Nested SVM: Improve interrupt injection
Date: Sun, 17 May 2009 09:48:57 +0300 [thread overview]
Message-ID: <20090517064857.GF3909@redhat.com> (raw)
In-Reply-To: <1242375740-31222-7-git-send-email-agraf@suse.de>
On Fri, May 15, 2009 at 10:22:20AM +0200, Alexander Graf wrote:
> static void svm_set_irq(struct kvm_vcpu *vcpu, int irq)
> {
> struct vcpu_svm *svm = to_svm(vcpu);
>
> - nested_svm_intr(svm);
> + if(!(svm->vcpu.arch.hflags & HF_GIF_MASK))
> + return;
>
Why would this function be called if HF_GIF_MASK is not set? This
check is done in svm_interrupt_allowed().
> - svm_queue_irq(vcpu, irq);
> + svm->vmcb->control.event_inj = irq |
> + SVM_EVTINJ_VALID | SVM_EVTINJ_TYPE_INTR;
> }
>
--
Gleb.
next prev parent reply other threads:[~2009-05-17 6:49 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 8:22 [PATCH 0/6] Add rudimentary Hyper-V guest support Alexander Graf
2009-05-15 8:22 ` [PATCH 1/6] Add definition for IGNNE MSR Alexander Graf
2009-05-15 8:22 ` [PATCH 2/6] MMU: don't bail on PAT bits in PTE Alexander Graf
2009-05-15 8:22 ` [PATCH 3/6] Emulator: Inject #PF when page was not found Alexander Graf
2009-05-15 8:22 ` [PATCH 4/6] Implement Hyper-V MSRs Alexander Graf
2009-05-15 8:22 ` [PATCH 5/6] Nested SVM: Implement INVLPGA Alexander Graf
2009-05-15 8:22 ` [PATCH 6/6] Nested SVM: Improve interrupt injection Alexander Graf
2009-05-17 6:48 ` Gleb Natapov [this message]
2009-05-17 8:10 ` Alexander Graf
2009-05-18 11:47 ` Alexander Graf
2009-05-15 13:43 ` [PATCH 5/6] Nested SVM: Implement INVLPGA Joerg Roedel
2009-05-17 20:02 ` Avi Kivity
2009-05-17 20:03 ` Avi Kivity
2009-05-18 18:46 ` Marcelo Tosatti
2009-05-18 13:00 ` Alexander Graf
2009-05-17 9:54 ` [PATCH 4/6] Implement Hyper-V MSRs Avi Kivity
2009-05-17 19:57 ` Alexander Graf
2009-05-17 20:00 ` Avi Kivity
2009-05-17 20:27 ` Alexander Graf
2009-05-17 20:37 ` Alexander Graf
2009-05-15 13:40 ` [PATCH 3/6] Emulator: Inject #PF when page was not found Joerg Roedel
2009-05-17 19:59 ` Avi Kivity
2009-05-17 20:25 ` Alexander Graf
2009-05-17 20:58 ` Avi Kivity
2009-05-18 12:55 ` Alexander Graf
2009-05-15 10:25 ` [PATCH 2/6] MMU: don't bail on PAT bits in PTE Michael S. Tsirkin
2009-05-15 10:53 ` Alexander Graf
2009-05-15 13:19 ` Joerg Roedel
2009-05-17 9:51 ` Avi Kivity
2009-05-15 10:47 ` [PATCH 0/6] Add rudimentary Hyper-V guest support Alexander Graf
2009-05-17 21:08 ` Avi Kivity
2009-05-18 12:45 ` Alexander Graf
2009-05-18 13:29 ` Avi Kivity
2009-05-18 13:35 ` Alexander Graf
2009-05-18 13:44 ` Avi Kivity
2009-05-18 15:15 ` Alexander Graf
2009-05-18 15:20 ` Avi Kivity
2009-05-18 15:24 ` Alexander Graf
2009-05-18 15:28 ` Avi Kivity
2009-05-18 15:32 ` Alexander Graf
2009-05-18 15:35 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090517064857.GF3909@redhat.com \
--to=gleb@redhat.com \
--cc=agraf@suse.de \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.