From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT aae9460] Basic qdev infrastructure.
Date: Sun, 17 May 2009 14:57:28 +0100 [thread overview]
Message-ID: <200905171457.28997.paul@codesourcery.com> (raw)
In-Reply-To: <f43fc5580905152312q7f664c07tc21243556538dcac@mail.gmail.com>
> > +struct DeviceProperty {
> > + int i;
>
> qdev_set_prop_int uses also 'int' but qdev_get_prop_int returns uint64_t.
Fixed.
> > +struct DeviceType {
> > + int size;
>
> size_t size?
Technically yes. However if we ever get devices with >2G of internal state we
have much bigger problems :-)
Paul
prev parent reply other threads:[~2009-05-17 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200905142138.n4ELcgVW027141@d01av02.pok.ibm.com>
2009-05-16 6:12 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT aae9460] Basic qdev infrastructure Blue Swirl
2009-05-17 13:57 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905171457.28997.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.