From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: sergk@sergk.org.ua, netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com
Subject: Re: [IGB 2.6.29.3 bug] Re: WARNING at dev_disable_lro when enabling ip_forward
Date: Mon, 18 May 2009 16:41:37 -0700 (PDT) [thread overview]
Message-ID: <20090518.164137.261504026.davem@davemloft.net> (raw)
In-Reply-To: <20090518160804.571431d2@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 18 May 2009 16:08:04 -0700
> On Mon, 18 May 2009 16:00:29 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
>
>> > @@ -2028,6 +2028,10 @@ static struct ethtool_ops igb_ethtool_ops = {
>> > .get_ethtool_stats = igb_get_ethtool_stats,
>> > .get_coalesce = igb_get_coalesce,
>> > .set_coalesce = igb_set_coalesce,
>> > +#ifdef CONFIG_IGB_LRO
>> > + .get_flags = ethtool_op_get_flags,
>> > + .set_flags = ethtool_op_set_flags,
>> > +#endif
>> > };
>> >
>> > void igb_set_ethtool_ops(struct net_device *netdev)
>
> For get, the ifdef is superflous, but for set you don't want
> the user to turn LRO on if not configured.
Stephen's right, ->set_flags has to be ifdef protected.
next prev parent reply other threads:[~2009-05-18 23:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 22:01 WARNING at dev_disable_lro when enabling ip_forward Sergey Kononenko
2009-05-18 22:35 ` [IGB 2.6.29.3 bug] " David Miller
2009-05-18 22:57 ` Stephen Hemminger
2009-05-18 23:00 ` David Miller
2009-05-18 23:07 ` Jeff Kirsher
2009-05-18 23:08 ` Stephen Hemminger
2009-05-18 23:41 ` David Miller [this message]
2009-05-19 20:46 ` Sergey Kononenko
2009-05-19 22:06 ` Jeff Kirsher
2009-05-19 22:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090518.164137.261504026.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sergk@sergk.org.ua \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.