From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1M64TG-0005ED-Os for mharc-grub-devel@gnu.org; Mon, 18 May 2009 11:09:42 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M64TE-0005BU-Fm for grub-devel@gnu.org; Mon, 18 May 2009 11:09:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M64T8-000576-Ur for grub-devel@gnu.org; Mon, 18 May 2009 11:09:39 -0400 Received: from [199.232.76.173] (port=46835 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M64T7-00056s-PV for grub-devel@gnu.org; Mon, 18 May 2009 11:09:34 -0400 Received: from gateway01.websitewelcome.com ([69.93.126.19]:60643) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1M64T7-0004TI-9Z for grub-devel@gnu.org; Mon, 18 May 2009 11:09:33 -0400 Received: (qmail 29631 invoked from network); 18 May 2009 15:12:02 -0000 Received: from gator297.hostgator.com (74.53.228.114) by gateway01.websitewelcome.com with SMTP; 18 May 2009 15:12:02 -0000 Received: from [67.185.177.95] (port=56417 helo=svelte.localnet) by gator297.hostgator.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1M64T4-0005WI-GF; Mon, 18 May 2009 10:09:30 -0500 From: Colin D Bennett To: grub-devel@gnu.org Date: Mon, 18 May 2009 08:09:25 -0700 User-Agent: KMail/1.11.2 (Linux/2.6.28-11-generic; KDE/4.2.2; x86_64; ; ) References: <20090517203642.GU3277@thorin> In-Reply-To: <20090517203642.GU3277@thorin> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2237733.vTC9pp6bqz"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200905180809.28579.colin@gibibit.com> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator297.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gibibit.com X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: Vladimir 'phcoder' Serbinenko , Robert Millan Subject: Re: [PATCH] gfxpayload X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2009 15:09:41 -0000 --nextPart2237733.vTC9pp6bqz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Robert Millan wrote on Sunday 17 May 2009: > Hi, > > On Sun, May 17, 2009 at 04:34:16PM +0200, Vladimir 'phcoder' Serbinenko=20 wrote: > > --- a/term/gfxterm.c > > +++ b/term/gfxterm.c > > @@ -27,10 +27,7 @@ > > #include > > #include > > > > -#define DEFAULT_VIDEO_WIDTH 640 > > -#define DEFAULT_VIDEO_HEIGHT 480 > > -#define DEFAULT_VIDEO_FLAGS 0 > > - > > +#define DEFAULT_VIDEO_MODE "1024x768,800x600,640x480" > > Our fonts / texts / menus in general are not prepared to cope well with > resolutions higher than 640x480. It works, but looks different/ugly. > Please leave that as default untill we solve those problems. I think the main problems at present are (1) the only provided font is GNU= =20 Unifont, which is fairly small (but I think it should work ok at sizes arou= nd=20 1024x768) and (2) my graphical menu themes currently support only absolute= =20 pixel positioning, so when the screen size is changed, they don't adapt (I= =20 really want to implement some sort of layout management system to handle=20 component layout consistently in the GUI). > Wrt changes in the video subsystem, as discussed on IRC this was discussed > before (me and Vesa, I think) and Vesa said he wanted to think about it. > Would be nice if we can reach consensus on this, and someone who's > familiarised with that area (not me) could approve those changes. > > But Vesa is on vacation... maybe Colin? I don't know. Try CCing them :-) I think your grub_video_set_mode() is a good change. In fact, I also moved= =20 that mode selection code out of gfxterm and into the video API in my graphi= cal=20 menu branch. It seems to me that there aren't significant changes to the video subsystem= =20 except that grub_video_setmode(width, height, mode_type) is removed and=20 replaced with a function that takes only a mode list string. I think this = is=20 fine since we should (once we get the above-mentioned issues resolved to=20 support various resolutions properly) never hard-code video mode info (exce= pt=20 for the 'videotest' command, perhaps; rather it should always be sourced fr= om=20 the user configuration, which means it will be a mode list string anyway. I had a minor comment regarding the patch: =2D-- a/video/video.c +++ b/video/video.c =2E.. +grub_err_t +grub_video_set_mode (char *modestring, + int NESTED_FUNC_ATTR (*hook) (grub_video_adapter_t p, + struct grub_video_mode_info *mode_info)) +{ + char *tmp; + char *next_mode; + char *current_mode; + char *param; + char *value; + char *modevar; + int width =3D -1; + int height =3D -1; + int depth =3D -1; + int flags =3D 0; + + /* Take copy of env.var. as we don't want to modify that. */ + modevar =3D grub_strdup (modestring); Since this is called in cases where 'modestring' is not an environment=20 variable, maybe it's more correct to just say, "Copy the mode list argument= =20 because it will be modified." I would declare modestring as 'const char *' to prevent accidental modification, especially since there is code that passes string constants f= or modestring. Regards, Colin --nextPart2237733.vTC9pp6bqz Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkoReiUACgkQokx8fzcGbYdTQACfTHetTV8joQGqsFIZXb9gyKqb fW8AnjqdvS2Ez5UTM84U0esVp3fOoqNW =m7Rq -----END PGP SIGNATURE----- --nextPart2237733.vTC9pp6bqz--