All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Alexandre Becholey <alexandre.becholey@epfl.ch>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH]rt73usb: fix for master mode.
Date: Mon, 18 May 2009 09:17:04 -0400	[thread overview]
Message-ID: <20090518131704.GC2814@tuxdriver.com> (raw)
In-Reply-To: <1242651336-12621-1-git-send-email-alexandre.becholey@epfl.ch>

On Mon, May 18, 2009 at 02:55:36PM +0200, Alexandre Becholey wrote:
> Report status unknown as if there were successfully transmitted.
> This will avoid hostapd to disassociate because it doesn't understand what a status unknown is.
> 
> Signed-off-by: Alexandre Becholey <alexandre.becholey@epfl.ch>
> ---
>  drivers/net/wireless/rt2x00/rt2x00dev.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 

Seems OK, but...

> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index f227084..0bbee06 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -280,6 +280,9 @@ void rt2x00lib_txdone(struct queue_entry *entry,
>  	if (!(tx_info->flags & IEEE80211_TX_CTL_NO_ACK)) {
>  		if (test_bit(TXDONE_SUCCESS, &txdesc->flags))
>  			tx_info->flags |= IEEE80211_TX_STAT_ACK;
> +                /* Report unkown status as if it was success */
> +                else if (test_bit(TXDONE_UNKNOWN, &txdesc->flags))
> +                        tx_info->flags |= IEEE80211_TX_STAT_ACK;
>  		else if (test_bit(TXDONE_FAILURE, &txdesc->flags))
>  			rt2x00dev->low_level_stats.dot11ACKFailureCount++;
>  	}

Please use tabs...

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2009-05-18 13:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18 12:55 [PATCH]rt73usb: fix for master mode Alexandre Becholey
2009-05-18 13:17 ` John W. Linville [this message]
2009-05-18 13:31 ` Ivo van Doorn
2009-05-18 14:42   ` Alexandre Becholey
2009-05-18 14:45     ` Ivo van Doorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090518131704.GC2814@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=alexandre.becholey@epfl.ch \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.