From mboxrd@z Thu Jan 1 00:00:00 1970 From: Piotr =?iso-8859-2?q?Zi=EAcik?= Subject: Re: [PATCH 08/12] mpc5121: Added I2C support. Date: Mon, 18 May 2009 15:57:11 +0200 Message-ID: <200905181557.11766.kosmo@semihalf.com> References: <1241640919-4650-1-git-send-email-wd@denx.de> <4A028182.3040107@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4A028182.3040107@grandegger.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@ozlabs.org To: Wolfgang Grandegger Cc: linuxppc-dev@ozlabs.org, Wolfgang Denk , Detlev Zundel , linux-i2c@vger.kernel.org List-Id: linux-i2c@vger.kernel.org > Right. Furthermore, the i2c-mpc.c should be extened to support bus speed > setting for the MPC512x, which has been merged recently (see commit id > f2bd5efe). I have simple question about bus speed setting support. Existing = implementation uses default safe speed if there is no 'clock-frequency' = property in i2c node. Comments in code suggest that this behaviour is left = for backward compatibility only. Should I make the 'clock-frequency' property mandatory for a new type of I2C controller (MPC5121) ? -- = Best Regards. Piotr Zi=EAcik From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from semihalf.com (semihalf.com [206.130.101.55]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A833CDE01F for ; Mon, 18 May 2009 23:57:30 +1000 (EST) From: Piotr =?iso-8859-2?q?Zi=EAcik?= To: Wolfgang Grandegger Subject: Re: [PATCH 08/12] mpc5121: Added I2C support. Date: Mon, 18 May 2009 15:57:11 +0200 References: <1241640919-4650-1-git-send-email-wd@denx.de> <4A028182.3040107@grandegger.com> In-Reply-To: <4A028182.3040107@grandegger.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Message-Id: <200905181557.11766.kosmo@semihalf.com> Cc: linuxppc-dev@ozlabs.org, Wolfgang Denk , Detlev Zundel , linux-i2c@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > Right. Furthermore, the i2c-mpc.c should be extened to support bus speed > setting for the MPC512x, which has been merged recently (see commit id > f2bd5efe). I have simple question about bus speed setting support. Existing=20 implementation uses default safe speed if there is no 'clock-frequency'=20 property in i2c node. Comments in code suggest that this behaviour is left= =20 for backward compatibility only. Should I make the 'clock-frequency' property mandatory for a new type of I2C controller (MPC5121) ? =2D-=20 Best Regards. Piotr Zi=EAcik