All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: number9652 <number9652@yahoo.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: e2fsprogs bmap problem
Date: Mon, 18 May 2009 12:32:06 -0400	[thread overview]
Message-ID: <20090518163206.GB27751@mit.edu> (raw)
In-Reply-To: <199598.89239.qm@web43514.mail.sp1.yahoo.com>

On Mon, May 18, 2009 at 07:56:38AM -0700, number9652 wrote:
> 
> I have looked at it a little more closely now, and to me it seems
> that we could add a new function like ext2fs_extent_open to accept
> an inode structure, as an alternative to changing the extent
> structure.

Yes, the right way to do this is to create a new function,
ext2fs_extent_open2() which takes a new parameter, struct inode
*inode, and then make ext2fs_extent_open() call ext2fs_extent_open2()
with the inode parameter set to NULL.  In ext2fs_extent_open2(), if
struct inode *inode is non-NULL, then we use it instead of reading in
the inode.  The one tricky bit is that we will need to use
ext2fs_read_inode() and ext2fs_write_inode() instead of
ext2fs_read_inode_full()/ext2fs_write_inode_full(), but that's OK; the
extents code didn't really need to pull in the full inode structure
anyway.

							- Ted

  reply	other threads:[~2009-05-18 16:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18 14:56 e2fsprogs bmap problem number9652
2009-05-18 16:32 ` Theodore Tso [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-05-15 20:49 number9652
2009-05-18  1:52 ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090518163206.GB27751@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=number9652@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.