From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Mon, 18 May 2009 23:25:09 +0200
Subject: [U-Boot] [PATCH] ARM DaVinci Leopard Board Support
In-Reply-To: <20090518204719.36403832E416@gemini.denx.de>
References: <1242225160-26706-1-git-send-email-s-paulraj@ti.com>
	<20090518202149.GG17539@game.jcrosoft.org>
	<20090518204719.36403832E416@gemini.denx.de>
Message-ID: <20090518212509.GK17539@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 22:47 Mon 18 May     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <20090518202149.GG17539@game.jcrosoft.org> you wrote:
> >
> > > +#ifndef __CONFIG_H
> > > +#define __CONFIG_H
> > > +#include <asm/sizes.h>
> > > +
> > > +
> > > +#define DAVINCI_LEOPARD
> > please CONFIG_
> 
> Or rather CONFIG_SYS_DAVINCI_LEOPARD
> 
> This is not a user-0selectable parameter, and such are fobidden
> outside the board config files anyway.
> 
> > > +#define CONFIG_SYS_NAND_SMALLPAGE
> > > +#define CONFIG_SYS_NAND_BASE_LIST	{ 0x02000000, }
> > please use macro
> 
> ??? Please explain what you mean here. This is a macro, isn't it?
replase 0x02000000 by DAVINCI_ASYNC_EMIF_DATA_CE0_BASE
> 
> > > +/* U-Boot general configuration */
> > > +#undef CONFIG_USE_IRQ				/* No IRQ/FIQ in U-Boot */
> > > +#define CONFIG_BOOTFILE		"uImage"	/* Boot file name */
> > > +#define CONFIG_SYS_PROMPT	"LEOPARD EVM # "
> > > +#define CONFIG_SYS_CBSIZE	1024		/* Console I/O Buffer Size  */
> > why 1k?
> 
> Why not? That's a config option...
just ask to known why they need 1K?

Best Regards,
J.