From: Ming Lei <tom.leiming@gmail.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
rostedt@goodmis.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, mingo@elte.hu
Subject: Re: [PATCH] ftrace:fix check for return value of register_module_notifier
Date: Mon, 18 May 2009 23:11:15 +0800 [thread overview]
Message-ID: <20090518231115.1cd598a2@linux-lm> (raw)
In-Reply-To: <20090518142507.GE4704@nowhere>
This patch fixes another check in event_trace_init.
Thanks.
>From 121f44b1658c137b8404756fdbd97dcf1d0c58f9 Mon Sep 17 00:00:00 2001
From: Ming Lei <tom.leiming@gmail.com>
Date: Mon, 18 May 2009 23:04:46 +0800
Subject: [PATCH] ftrace:fix check for return value of register_module_notifier in event_trace_init
return zero should be correct, so fix it.
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Reported-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
---
kernel/trace/trace_events.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 0eec0c5..9e91c4a 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -1174,7 +1174,7 @@ static __init int event_trace_init(void)
}
ret = register_module_notifier(&trace_module_nb);
- if (!ret)
+ if (ret)
pr_warning("Failed to register trace events module notifier\n");
return 0;
--
1.6.0.GIT
--
Lei Ming
next prev parent reply other threads:[~2009-05-18 15:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-17 7:31 [PATCH] ftrace:fix check for return value of register_module_notifier tom.leiming
2009-05-17 13:06 ` Frederic Weisbecker
2009-05-18 0:54 ` Li Zefan
2009-05-18 1:40 ` Ming Lei
2009-05-18 12:39 ` Ming Lei
2009-05-18 14:25 ` Frederic Weisbecker
2009-05-18 15:11 ` Ming Lei [this message]
2009-05-18 9:06 ` [tip:tracing/core] tracing: fix " tip-bot for Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090518231115.1cd598a2@linux-lm \
--to=tom.leiming@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.