From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qemu: cleanup default_write_config
Date: Tue, 19 May 2009 11:11:04 -0300 [thread overview]
Message-ID: <20090519141104.GA4859@amt.cnet> (raw)
In-Reply-To: <20090519085632.GA29160@redhat.com>
On Tue, May 19, 2009 at 11:56:32AM +0300, Michael S. Tsirkin wrote:
> On Mon, May 04, 2009 at 01:01:22AM +0300, Michael S. Tsirkin wrote:
> > Change pci default write config to use symbolic constants and a table-driven
> > design: add a mask table with writable bits set and readonly bits unset.
> > This makes it much easier to support multi-byte registers.
> >
> > As a result, writing a single byte in BAR registers now works as
> > it should. Writing to upper limit registers in the bridge
> > also works as it should. Code is also shorter.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Any feedback on this patch?
> I'd like to use mask table as the basis for MSI integration work (setting
> up appropriate masks for capability bits) and if there are issues with
> this approach, I'd like to know.
Don't see any problem with it.
prev parent reply other threads:[~2009-05-19 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-03 22:01 [Qemu-devel] [PATCH] qemu: cleanup default_write_config Michael S. Tsirkin
2009-05-19 8:56 ` Michael S. Tsirkin
2009-05-19 14:11 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090519141104.GA4859@amt.cnet \
--to=mtosatti@redhat.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.