From: Frans Pop <elendil@planet.nl>
To: Subrata Modak <subrata@linux.vnet.ibm.com>
Cc: x86@kernel.org, sachinp@linux.vnet.ibm.com, hpa@zytor.com,
andi@firstfloor.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org, mingo@redhat.com,
subrata@linux.vnet.ibm.com, balbir@linux.vnet.ibm.com
Subject: Re: [PATCH] Remove indirect variable usage at arch/x86/kernel/tsc.c
Date: Tue, 19 May 2009 20:53:57 +0200 [thread overview]
Message-ID: <200905192054.00377.elendil@planet.nl> (raw)
In-Reply-To: <20090519180302.603.3124.sendpatchset@subratamodak.linux.ibm.com>
Subrata Modak wrote:
> 640 if (!(freq->flags & CPUFREQ_CONST_LOOPS))
> 641 #ifdef CONFIG_SMP
> 642 lpj = &cpu_data(freq->cpu).loops_per_jiffy;
> 643 #else
> 644 lpj = &boot_cpu_data.loops_per_jiffy;
> 645 #endif
No comments on your patch, but it might be good to also fix the incorrect
indentation here: line 644 needs an extra tab.
Cheers,
FJP
next prev parent reply other threads:[~2009-05-19 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 18:03 [PATCH] Remove indirect variable usage at arch/x86/kernel/tsc.c Subrata Modak
2009-05-19 18:53 ` Frans Pop [this message]
2009-05-20 6:10 ` Subrata Modak
2009-05-24 19:42 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905192054.00377.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=andi@firstfloor.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sachinp@linux.vnet.ibm.com \
--cc=subrata@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.