From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Martin Knoblauch <spamtrap@knobisoft.de>,
Matt Mackall <mpm@selenic.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Rgeression: 2.6.30-rc6-git3 build error - ICE from drivers/char/random.c
Date: Wed, 20 May 2009 09:53:18 +0200 [thread overview]
Message-ID: <20090520075318.GA23959@elte.hu> (raw)
In-Reply-To: <alpine.LFD.2.01.0905191122320.3301@localhost.localdomain>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Tue, 19 May 2009, Linus Torvalds wrote:
> >
> > I guess getting rid of 'jiffies' is also worth it. Even at its very worst,
> > 'get_cycles()' should return jiffy-level information, so adding in jiffies
> > doesn't add anything to it.
>
> I take that back. If there isno TSC at all, "get_cycles()" might
> just be returning zero. So the jiffies fallback is probably better
> than nothing.
>
> So I'll just remove the (long)&ret part. [...]
I suspect we could add current_thread_info() or 'current' to it - as
they are initialized variables. (which the stack pointer mostly
boils down to - the stack depth is predictable)
Not worth the trouble though i suspect.
Ingo
next prev parent reply other threads:[~2009-05-20 7:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 13:29 Rgeression: 2.6.30-rc6-git3 build error - ICE from drivers/char/random.c Martin Knoblauch
2009-05-18 20:34 ` Matt Mackall
2009-05-18 22:29 ` Linus Torvalds
2009-05-19 9:20 ` Martin Knoblauch
2009-05-19 15:09 ` Linus Torvalds
2009-05-19 17:52 ` Martin Knoblauch
2009-05-19 18:08 ` Linus Torvalds
2009-05-19 18:24 ` Linus Torvalds
2009-05-19 19:00 ` Martin Knoblauch
2009-05-20 7:53 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-05-18 12:58 Martin Knoblauch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520075318.GA23959@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=spamtrap@knobisoft.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.