From: Andi Kleen <andi@firstfloor.org>
To: Chris Peterson <cpeterso@cpeterso.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: [RFC] mod_timer() helper functions?
Date: Wed, 20 May 2009 10:14:43 +0200 [thread overview]
Message-ID: <20090520081443.GA8684@one.firstfloor.org> (raw)
In-Reply-To: <a24804730905200011l202733abh89f5d4feaf69610e@mail.gmail.com>
> /**
> * timer_settime_msecs - modify a timer's timeout
> * @timer: the timer to be modified
> * @msecs: minimum time in milliseconds to sleep for
> */
> int timer_settime_msecs(struct timer_list *timer, int msecs)
At least this function needs something that indicates it is very approximate
(upto 900% error for 1ms with HZ=100)
The old open coded pattern showed this.
Or perhaps better drop the msecs version and just keep the seconds version.
People who want msecs accuracy likely should use hrtimers anyways.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-05-20 8:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-16 7:36 [RFC] mod_timer() helper functions? Chris Peterson
2009-05-17 6:03 ` Andrew Morton
2009-05-17 7:50 ` Chris Peterson
2009-05-17 8:03 ` Andrew Morton
2009-05-17 12:13 ` Thomas Gleixner
2009-05-18 7:14 ` Andi Kleen
2009-05-20 7:11 ` Chris Peterson
2009-05-20 8:14 ` Andi Kleen [this message]
2009-05-21 5:11 ` Chris Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520081443.GA8684@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=cpeterso@cpeterso.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.