All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>,
	Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	John Kacur <jkacur@redhat.com>
Subject: [PATCH 3/4] perf_counter: optimize disable of time based sw counters
Date: Wed, 20 May 2009 12:21:21 +0200	[thread overview]
Message-ID: <20090520102553.388185031@chello.nl> (raw)
In-Reply-To: 20090520102118.377477360@chello.nl

[-- Attachment #1: perf_counter-opt-swcounter-disable-hrtimer.patch --]
[-- Type: text/plain, Size: 1075 bytes --]

Currently we call hrtimer_cancel() unconditionally on disable of time based
software counters. Avoid when possible.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
 kernel/perf_counter.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Index: linux-2.6/kernel/perf_counter.c
===================================================================
--- linux-2.6.orig/kernel/perf_counter.c
+++ linux-2.6/kernel/perf_counter.c
@@ -2716,7 +2716,8 @@ static int cpu_clock_perf_counter_enable
 
 static void cpu_clock_perf_counter_disable(struct perf_counter *counter)
 {
-	hrtimer_cancel(&counter->hw.hrtimer);
+	if (counter->hw.irq_period)
+		hrtimer_cancel(&counter->hw.hrtimer);
 	cpu_clock_perf_counter_update(counter);
 }
 
@@ -2767,7 +2768,8 @@ static int task_clock_perf_counter_enabl
 
 static void task_clock_perf_counter_disable(struct perf_counter *counter)
 {
-	hrtimer_cancel(&counter->hw.hrtimer);
+	if (counter->hw.irq_period)
+		hrtimer_cancel(&counter->hw.hrtimer);
 	task_clock_perf_counter_update(counter, counter->ctx->time);
 
 }

-- 


  parent reply	other threads:[~2009-05-20 10:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-20 10:21 [PATCH 0/4] perf counter bits Peter Zijlstra
2009-05-20 10:21 ` [PATCH 1/4] perf_counter: solve the rotate_ctx vs inherit race differently Peter Zijlstra
2009-05-20 17:18   ` [tip:perfcounters/core] perf_counter: Solve " tip-bot for Peter Zijlstra
2009-05-20 10:21 ` [PATCH 2/4] perf_counter: log irq_period changes Peter Zijlstra
2009-05-20 17:18   ` [tip:perfcounters/core] perf_counter: Log " tip-bot for Peter Zijlstra
2009-05-20 10:21 ` Peter Zijlstra [this message]
2009-05-20 17:19   ` [tip:perfcounters/core] perf_counter: Optimize disable of time based sw counters tip-bot for Peter Zijlstra
2009-05-20 10:21 ` [PATCH 4/4] perf_counter: optimize sched in/out of counters Peter Zijlstra
2009-05-20 17:19   ` [tip:perfcounters/core] perf_counter: Optimize " tip-bot for Peter Zijlstra
2009-05-20 10:48 ` [PATCH 0/4] perf counter bits Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090520102553.388185031@chello.nl \
    --to=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.