From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian =?iso-8859-1?q?Borntr=E4ger?= Date: Wed, 20 May 2009 10:38:15 +0000 Subject: Re: Are the cast necessary in function "kfree"? Message-Id: <200905201238.16160.borntrae@de.ibm.com> List-Id: References: <5c43c2d40905200330p5b14be2ey567bc493374e09b3@mail.gmail.com> In-Reply-To: <5c43c2d40905200330p5b14be2ey567bc493374e09b3@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: =?iso-8859-1?q?Andr=E9_Lopes?= Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Am Mittwoch 20 Mai 2009 12:30:21 schrieb Andr=E9 Lopes: I only looked at the s390 parts: > arch/s390/include/asm/idals.h:110: kfree((void *)(unsigned long) ccw->cda= ); This cast is necessary since cda is an u32 even on 64bit machines. > drivers/s390/char/vmur.c:188: kfree((void *)(addr_t) ptr->cda); dito. Christian -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754750AbZETKjS (ORCPT ); Wed, 20 May 2009 06:39:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753334AbZETKjD (ORCPT ); Wed, 20 May 2009 06:39:03 -0400 Received: from mtagate7.de.ibm.com ([195.212.29.156]:52895 "EHLO mtagate7.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752811AbZETKjC convert rfc822-to-8bit (ORCPT ); Wed, 20 May 2009 06:39:02 -0400 From: Christian =?iso-8859-1?q?Borntr=E4ger?= Organization: IBM To: =?iso-8859-1?q?Andr=E9_Lopes?= Subject: Re: Are the cast necessary in function "kfree"? Date: Wed, 20 May 2009 12:38:15 +0200 User-Agent: KMail/1.11.2 (Linux/2.6.30-rc6-self-00043-g22ef37e; KDE/4.2.2; i686; ; ) Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <5c43c2d40905200330p5b14be2ey567bc493374e09b3@mail.gmail.com> In-Reply-To: <5c43c2d40905200330p5b14be2ey567bc493374e09b3@mail.gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <200905201238.16160.borntrae@de.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch 20 Mai 2009 12:30:21 schrieb André Lopes: I only looked at the s390 parts: > arch/s390/include/asm/idals.h:110: kfree((void *)(unsigned long) ccw->cda); This cast is necessary since cda is an u32 even on 64bit machines. > drivers/s390/char/vmur.c:188: kfree((void *)(addr_t) ptr->cda); dito. Christian