From: Evgeniy Polyakov <zbr@ioremap.net>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org, Patrick McHardy <kaber@trash.net>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] crypto: hifn_795x - fix __dev{init,exit} markings
Date: Wed, 20 May 2009 18:56:23 +0400 [thread overview]
Message-ID: <20090520145623.GA4147@ioremap.net> (raw)
In-Reply-To: <1242633110-16344-1-git-send-email-vapier@gentoo.org>
Hi Mike.
On Mon, May 18, 2009 at 03:51:50AM -0400, Mike Frysinger (vapier@gentoo.org) wrote:
> The remove member of the pci_driver hifn_pci_driver uses __devexit_p(),
> so the remove function itself should be marked with __devexit. And where
> there be __devexit on the remove, so is there __devinit on the probe.
>
> Similarly, the module_init/module_exit functions should be declared with
> plain __init/__exit markings, not the hotplug __dev{init,exit} ones.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> CC: Evgeniy Polyakov <zbr@ioremap.net>
> CC: Patrick McHardy <kaber@trash.net>
Looks good, thank you Mike.
Ack. Herbert, please apply.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2009-05-20 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 7:51 [PATCH] crypto: hifn_795x - fix __dev{init,exit} markings Mike Frysinger
2009-05-20 14:56 ` Evgeniy Polyakov [this message]
2009-05-27 5:16 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520145623.GA4147@ioremap.net \
--to=zbr@ioremap.net \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.