From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 4/6] cr: checkpoint and restore task credentials Date: Wed, 20 May 2009 16:52:50 -0500 Message-ID: <20090520215250.GB3517@us.ibm.com> References: <20090519014446.GA28277@us.ibm.com> <20090519014538.GD28312@us.ibm.com> <4A1435E0.3010306@cs.columbia.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4A1435E0.3010306-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oren Laadan Cc: Linux Containers , David Howells List-Id: containers.vger.kernel.org Quoting Oren Laadan (orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org): > > /* read the task_struct into the current task */ > > -static int restore_task_struct(struct ckpt_ctx *ctx) > > +static int restore_task_struct(struct ckpt_ctx *ctx, struct cred **realcredp, > > + struct cred **ecredp) > > ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ > > This probably belongs to restore_task_shared() ? Why? The task->cred and task->ecred are task properties, so their reference should be stored in the ckpt_hdr_task->cred_ref and ckpt_hdr_task->ecred_ref, no? -serge