From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api Date: Thu, 21 May 2009 16:46:50 +0300 Message-ID: <20090521134650.GI25309@redhat.com> References: <20090520162130.GA22109@redhat.com> <200905211409.33325.paul@codesourcery.com> <20090521131231.GH25309@redhat.com> <200905211423.20843.paul@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , qemu-devel@nongnu.org, Carsten Otte , kvm@vger.kernel.org, Rusty Russell , virtualization@lists.linux-foundation.org, Christian Borntraeger To: Paul Brook Return-path: Received: from mx2.redhat.com ([66.187.237.31]:49996 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753817AbZEUNtz (ORCPT ); Thu, 21 May 2009 09:49:55 -0400 Content-Disposition: inline In-Reply-To: <200905211423.20843.paul@codesourcery.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, May 21, 2009 at 02:23:20PM +0100, Paul Brook wrote: > > > MSI provides multiple edge triggered interrupts, whereas traditional mode > > > provides a single level triggered interrupt. My guess is most devices > > > will want to treat these differently anyway. > > > > So, is qemu_send_msi better than qemu_set_irq. > > Neither. pci_send_msi, Works for me. > which is a trivial wrapper around stl_phys. OK, but I'm adding another level of indirection in the middle, to allow us to tie in a kvm backend. -- MST