From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api Date: Thu, 21 May 2009 14:23:20 +0100 Message-ID: <200905211423.20843.paul@codesourcery.com> References: <20090520162130.GA22109@redhat.com> <200905211409.33325.paul@codesourcery.com> <20090521131231.GH25309@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Avi Kivity , qemu-devel@nongnu.org, Carsten Otte , kvm@vger.kernel.org, Rusty Russell , virtualization@lists.linux-foundation.org, Christian Borntraeger To: "Michael S. Tsirkin" Return-path: Received: from mail.codesourcery.com ([65.74.133.4]:38059 "EHLO mail.codesourcery.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219AbZEUNXV (ORCPT ); Thu, 21 May 2009 09:23:21 -0400 In-Reply-To: <20090521131231.GH25309@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: > > MSI provides multiple edge triggered interrupts, whereas traditional mode > > provides a single level triggered interrupt. My guess is most devices > > will want to treat these differently anyway. > > So, is qemu_send_msi better than qemu_set_irq. Neither. pci_send_msi, which is a trivial wrapper around stl_phys. Paul