From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: Len Brown <lenb@kernel.org>, linux-acpi <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] ACPI: Disable ARB_DISABLE on platforms where it is not needed
Date: Fri, 22 May 2009 00:53:27 +0100 [thread overview]
Message-ID: <20090521235327.GA2064@srcf.ucam.org> (raw)
In-Reply-To: <20090521234813.GA11561@linux-os.sc.intel.com>
On Thu, May 21, 2009 at 04:48:13PM -0700, Pallipadi, Venkatesh wrote:
> + /*
> + * On all recent platforms, ARB_DISABLE is a nop.
> + * So, set bm_control to zero to indicate that ARB_DISABLE
> + * is not required while entering C3 type state on
> + * P4, Core and beyond CPUs
> + */
> + if (c->x86_vendor == X86_VENDOR_INTEL &&
To me, "All recent platforms" is not quite the same as "All recent Intel
platforms" :) Is this true of any other vendors? If not, the comment
could be clarified a little.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-05-21 23:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 23:48 [PATCH] ACPI: Disable ARB_DISABLE on platforms where it is not needed Pallipadi, Venkatesh
2009-05-21 23:53 ` Matthew Garrett [this message]
2009-05-22 0:09 ` Pallipadi, Venkatesh
2009-05-28 1:57 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090521235327.GA2064@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.