All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v0 3/3] Build in git-rebase.sh
Date: Sat, 23 May 2009 19:26:03 +1000	[thread overview]
Message-ID: <20090523092603.GA7420@dektop> (raw)
In-Reply-To: <fcaeb9bf0905220030l45e1b7dfqd30f35b7c8e43b51@mail.gmail.com>

On Fri, May 22, 2009 at 05:30:31PM +1000, Nguyen Thai Ngoc Duy wrote:
> 2009/5/22 Johannes Sixt <j.sixt@viscovery.net>:
> > Nguyễn Thái Ngọc Duy schrieb:
> >> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> >
> > Is it possible for you to test this series on Windows? Many rebase tests
> > fail, but I haven't investigated why.
> 
> I'll try it this weekend.

This patch makes t3*rebase*.sh pass for me except t3412 (more exactly
t3412.8). That test failed even with git-rebase.sh. Hmm... Anyway
could you try again to see what tests still fail?

--<--
diff --git a/builtin-rebase.c b/builtin-rebase.c
index 2acea59..5582f1d 100644
--- a/builtin-rebase.c
+++ b/builtin-rebase.c
@@ -56,7 +56,8 @@ static int rebase_config(const char *var, const char *value, void *data)
 			((struct rebase_opt*)data)->flags |= REBASE_STAT;
 		return 0;
 	}
-	return 0;
+
+	return git_default_config(var, value, data);
 }
 
 /* utility functions */
@@ -504,7 +505,7 @@ static void run_interactive(int argc, const char **argv)
 	ret = run_command(&cp);
 	if (IS_RUN_COMMAND_ERR(ret))
 		die("Failed to run git rebase--interactive");
-	exit(ret);
+	exit(-ret);
 }
 
 /* from diff.c */
--<--

  reply	other threads:[~2009-05-23  9:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-21  9:47 [PATCH v0 1/3] doc/git-rebase.txt: remove mention of multiple strategies Nguyễn Thái Ngọc Duy
2009-05-21  9:47 ` [PATCH v0 2/3] t/t3400-rebase.sh: add more tests to help migrating git-rebase.sh to C Nguyễn Thái Ngọc Duy
2009-05-21  9:47   ` [PATCH v0 3/3] Build in git-rebase.sh Nguyễn Thái Ngọc Duy
2009-05-21 10:25     ` Jakub Narebski
2009-05-21 10:44       ` Nguyen Thai Ngoc Duy
2009-05-21 12:29         ` Jakub Narebski
2009-05-21 22:57           ` Nguyen Thai Ngoc Duy
2009-05-21 14:39     ` Junio C Hamano
2009-05-22  6:56     ` Johannes Sixt
2009-05-22  7:30       ` Nguyen Thai Ngoc Duy
2009-05-23  9:26         ` Nguyen Thai Ngoc Duy [this message]
2009-05-23 14:50           ` Nguyen Thai Ngoc Duy
2009-05-25  6:16             ` Johannes Sixt
2009-05-25  6:34               ` Nguyen Thai Ngoc Duy
2009-05-25  6:47                 ` Johannes Sixt
2009-05-25  7:00                   ` Nguyen Thai Ngoc Duy
2009-05-25  7:39                     ` Nguyen Thai Ngoc Duy
2009-05-21 10:22   ` [PATCH v0 2/3] t/t3400-rebase.sh: add more tests to help migrating git-rebase.sh to C Jakub Narebski
2009-05-21 10:39     ` Nguyen Thai Ngoc Duy
2009-05-21 14:22   ` Junio C Hamano
2009-05-23 15:31     ` [PATCH " Nguyễn Thái Ngọc Duy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090523092603.GA7420@dektop \
    --to=pclouds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.sixt@viscovery.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.