From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] net: switch device init to initcall
Date: Sat, 23 May 2009 18:36:00 +0200 [thread overview]
Message-ID: <20090523163600.GD26561@game.jcrosoft.org> (raw)
In-Reply-To: <f8328f7c0905230841k67b7f944x3b95aae65e13eabb@mail.gmail.com>
On 08:41 Sat 23 May , Ben Warren wrote:
> Jean-Christophe,
>
> On Sat, May 23, 2009 at 8:08 AM, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj@jcrosoft.com> wrote:
>
> apply to at91sam9263ek
>
> this will result to reduce the size of 2212 bytes
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> board/atmel/at91sam9263ek/at91sam9263ek.c | 12 ++++++------
> include/netdev.h | 12 ------------
> net/eth.c | 16 ----------------
> 3 files changed, 6 insertions(+), 34 deletions(-)
>
> <snip>
>
> - /* Try board-specific initialization first. If it fails or
> isn't
> - * present, try the cpu-specific initialization */
> - if (board_eth_init(bis) < 0)
> - cpu_eth_init(bis);
>
> Good idea, but your implementation is flawed. It's critically important
> that the prioritization of board ethernet initialization over CPU ethernet
> initialization be preserved. Your idea doesn't handle that (at least that
> I can see).
with this only patch yes, but I'm preparing a full implementation that will
If I understand correctly the board_eth_init is unsed to overwrite the default
cpu_eth_init by passing different parameter
with a device/driver model this will be handle correctly
Best Regards,
J.
next prev parent reply other threads:[~2009-05-23 16:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-23 15:05 [U-Boot] [RFC] initcall mechanism introduction Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <1243091325-27683-1-git-send-email-plagnioj@jcrosoft.com>
2009-05-23 15:08 ` [U-Boot] [PATCH 2/3] arm: add initcalls_init Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 15:08 ` [U-Boot] [PATCH 3/3] net: switch device init to initcall Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 15:41 ` Ben Warren
2009-05-23 16:36 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-05-23 18:26 ` Wolfgang Denk
2009-05-23 18:31 ` Ben Warren
2009-05-23 18:19 ` [U-Boot] [RFC] initcall mechanism introduction Wolfgang Denk
2009-05-24 12:00 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-24 14:57 ` Wolfgang Denk
2009-05-24 15:04 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-24 17:05 ` Wolfgang Denk
2009-05-26 21:00 ` Scott Wood
2009-05-26 21:54 ` Wolfgang Denk
2009-05-26 22:07 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-26 22:25 ` Wolfgang Denk
2009-05-26 22:20 ` Scott Wood
2009-05-26 22:28 ` Wolfgang Denk
2009-05-27 7:52 ` Haavard Skinnemoen
2009-05-27 8:12 ` Stefan Roese
2009-05-27 18:48 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090523163600.GD26561@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.