From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 02/38] utsns: extract create_uts_ns() Date: Sun, 24 May 2009 17:37:21 -0500 Message-ID: <20090524223721.GA12734@hallyn.com> References: <1242968132-1044-1-git-send-email-adobriyan@gmail.com> <1242968132-1044-2-git-send-email-adobriyan@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1242968132-1044-2-git-send-email-adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Alexey Dobriyan Cc: xemul-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, mingo-X9Un+BFzKDI@public.gmane.org List-Id: containers.vger.kernel.org Quoting Alexey Dobriyan (adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org): > create_uts_ns() will be used by C/R to create fresh uts_ns. > > Signed-off-by: Alexey Dobriyan Acked-by: Serge Hallyn > --- > kernel/utsname.c | 13 +++++++++++-- > 1 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/kernel/utsname.c b/kernel/utsname.c > index 815237a..8a82b4b 100644 > --- a/kernel/utsname.c > +++ b/kernel/utsname.c > @@ -15,6 +15,16 @@ > #include > #include > > +static struct uts_namespace *create_uts_ns(void) > +{ > + struct uts_namespace *uts_ns; > + > + uts_ns = kmalloc(sizeof(struct uts_namespace), GFP_KERNEL); > + if (uts_ns) > + kref_init(&uts_ns->kref); > + return uts_ns; > +} > + > /* > * Clone a new ns copying an original utsname, setting refcount to 1 > * @old_ns: namespace to clone > @@ -24,14 +34,13 @@ static struct uts_namespace *clone_uts_ns(struct uts_namespace *old_ns) > { > struct uts_namespace *ns; > > - ns = kmalloc(sizeof(struct uts_namespace), GFP_KERNEL); > + ns = create_uts_ns(); > if (!ns) > return ERR_PTR(-ENOMEM); > > down_read(&uts_sem); > memcpy(&ns->name, &old_ns->name, sizeof(ns->name)); > up_read(&uts_sem); > - kref_init(&ns->kref); > return ns; > } > > -- > 1.5.6.5 > > _______________________________________________ > Containers mailing list > Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org > https://lists.linux-foundation.org/mailman/listinfo/containers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760862AbZEXWdl (ORCPT ); Sun, 24 May 2009 18:33:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760711AbZEXWcb (ORCPT ); Sun, 24 May 2009 18:32:31 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:53184 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759674AbZEXWca (ORCPT ); Sun, 24 May 2009 18:32:30 -0400 Date: Sun, 24 May 2009 17:37:21 -0500 From: "Serge E. Hallyn" To: Alexey Dobriyan Cc: akpm@linux-foundation.org, xemul@parallels.com, containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, dave@linux.vnet.ibm.com, mingo@elte.hu, torvalds@linux-foundation.org Subject: Re: [PATCH 02/38] utsns: extract create_uts_ns() Message-ID: <20090524223721.GA12734@hallyn.com> References: <1242968132-1044-1-git-send-email-adobriyan@gmail.com> <1242968132-1044-2-git-send-email-adobriyan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1242968132-1044-2-git-send-email-adobriyan@gmail.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Alexey Dobriyan (adobriyan@gmail.com): > create_uts_ns() will be used by C/R to create fresh uts_ns. > > Signed-off-by: Alexey Dobriyan Acked-by: Serge Hallyn > --- > kernel/utsname.c | 13 +++++++++++-- > 1 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/kernel/utsname.c b/kernel/utsname.c > index 815237a..8a82b4b 100644 > --- a/kernel/utsname.c > +++ b/kernel/utsname.c > @@ -15,6 +15,16 @@ > #include > #include > > +static struct uts_namespace *create_uts_ns(void) > +{ > + struct uts_namespace *uts_ns; > + > + uts_ns = kmalloc(sizeof(struct uts_namespace), GFP_KERNEL); > + if (uts_ns) > + kref_init(&uts_ns->kref); > + return uts_ns; > +} > + > /* > * Clone a new ns copying an original utsname, setting refcount to 1 > * @old_ns: namespace to clone > @@ -24,14 +34,13 @@ static struct uts_namespace *clone_uts_ns(struct uts_namespace *old_ns) > { > struct uts_namespace *ns; > > - ns = kmalloc(sizeof(struct uts_namespace), GFP_KERNEL); > + ns = create_uts_ns(); > if (!ns) > return ERR_PTR(-ENOMEM); > > down_read(&uts_sem); > memcpy(&ns->name, &old_ns->name, sizeof(ns->name)); > up_read(&uts_sem); > - kref_init(&ns->kref); > return ns; > } > > -- > 1.5.6.5 > > _______________________________________________ > Containers mailing list > Containers@lists.linux-foundation.org > https://lists.linux-foundation.org/mailman/listinfo/containers