From: Oleg Nesterov <oleg@redhat.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
ebiederm@xmission.com, roland@redhat.com,
linux-kernel@vger.kernel.org, Matthew Wilcox <matthew@wil.cx>
Subject: Re: [PATCH 1/1] signal: make group kill signal fatal
Date: Mon, 25 May 2009 02:07:50 +0200 [thread overview]
Message-ID: <20090525000750.GA2301@redhat.com> (raw)
In-Reply-To: <1243198054-13816-1-git-send-email-jirislaby@gmail.com>
On 05/24, Jiri Slaby wrote:
>
> __fatal_signal_pending() returns now true only for a non-group sent
> sigkill, i. e. for example tgkill, send_sig...
No. Please look at complete_signal(). If we queue a fatal signal,
we always add SIGKILL to any thread.
> Use sigkill_pending()
Please do not use it, it should die.
> in __fatal_signal_pending() which adds a test also
> for shared_pending queue.
See above. Afaics this is not needed.
> Also grab siglock in __fatal_signal_pending().
This is wrong. It can be called when the task has already died
and its ->signal == NULL.
Oleg.
next prev parent reply other threads:[~2009-05-25 0:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-24 20:47 [PATCH 1/1] signal: make group kill signal fatal Jiri Slaby
2009-05-25 0:07 ` Oleg Nesterov [this message]
2009-05-25 16:21 ` Jiri Slaby
2009-05-25 17:20 ` Oleg Nesterov
2009-05-25 18:15 ` Jiri Slaby
2009-05-25 22:51 ` Oleg Nesterov
2009-06-02 12:54 ` Jiri Slaby
2009-06-02 14:50 ` Oleg Nesterov
2009-06-03 1:52 ` Roland McGrath
2009-06-04 2:27 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090525000750.GA2301@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.