From: Jens Axboe <jens.axboe@oracle.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org,
akpm@linux-foundation.org, yanmin_zhang@linux.intel.com
Subject: Re: [PATCH 06/12] writeback: separate the flushing state/task from the bdi
Date: Mon, 25 May 2009 12:36:24 +0200 [thread overview]
Message-ID: <20090525103623.GU11363@kernel.dk> (raw)
In-Reply-To: <20090525101323.GD23546@duck.suse.cz>
On Mon, May 25 2009, Jan Kara wrote:
> On Mon 25-05-09 09:34:41, Jens Axboe wrote:
> > Add a struct bdi_writeback for tracking and handling dirty IO. This
> > is in preparation for adding > 1 flusher task per bdi.
> >
> > Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
> ...
> > static int bdi_start_fn(void *ptr)
> > {
> > - struct backing_dev_info *bdi = ptr;
> > + struct bdi_writeback *wb = ptr;
> > + struct backing_dev_info *bdi = wb->bdi;
> > struct task_struct *tsk = current;
> > -
> > - /*
> > - * Add us to the active bdi_list
> > - */
> > - mutex_lock(&bdi_lock);
> > - list_add(&bdi->bdi_list, &bdi_list);
> > - mutex_unlock(&bdi_lock);
> I'm probably missing something but I cannot find where the bdi is added
> to the bdi_list after this patch...
For some reason, that part is now in the following patch. The two hunks
should just be deleted, good catch!
--
Jens Axboe
next prev parent reply other threads:[~2009-05-25 10:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 7:34 [PATCH 0/12] Per-bdi writeback flusher threads #5 Jens Axboe
2009-05-25 7:34 ` [PATCH 01/12] ntfs: remove old debug check for dirty data in ntfs_put_super() Jens Axboe
2009-05-25 7:34 ` [PATCH 02/12] btrfs: properly register fs backing device Jens Axboe
2009-05-25 7:34 ` [PATCH 03/12] writeback: move dirty inodes from super_block to backing_dev_info Jens Axboe
2009-05-25 8:42 ` Jan Kara
2009-05-25 8:51 ` Jens Axboe
2009-05-25 7:34 ` [PATCH 04/12] writeback: switch to per-bdi threads for flushing data Jens Axboe
2009-05-25 9:58 ` Jan Kara
2009-05-25 10:34 ` Jens Axboe
2009-05-25 12:10 ` Jan Kara
2009-05-25 12:16 ` Jens Axboe
2009-05-25 12:34 ` Jan Kara
2009-05-26 8:56 ` Jens Axboe
2009-05-26 8:59 ` Christoph Hellwig
2009-05-26 9:07 ` Jens Axboe
2009-05-25 7:34 ` [PATCH 05/12] writeback: get rid of pdflush completely Jens Axboe
2009-05-25 7:34 ` [PATCH 06/12] writeback: separate the flushing state/task from the bdi Jens Axboe
2009-05-25 10:13 ` Jan Kara
2009-05-25 10:36 ` Jens Axboe [this message]
2009-05-25 7:34 ` [PATCH 07/12] writeback: support > 1 flusher thread per bdi Jens Axboe
2009-05-25 7:34 ` [PATCH 08/12] writeback: include default_backing_dev_info in writeback Jens Axboe
2009-05-25 7:34 ` [PATCH 09/12] writeback: allow sleepy exit of default writeback task Jens Axboe
2009-05-25 7:34 ` [PATCH 10/12] writeback: add some debug inode list counters to bdi stats Jens Axboe
2009-05-25 7:34 ` [PATCH 11/12] writeback: add name to backing_dev_info Jens Axboe
2009-05-25 7:34 ` [PATCH 12/12] writeback: check for registered bdi in flusher add and inode dirty Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2009-05-26 9:33 [PATCH 0/12] Per-bdi writeback flusher threads v7 Jens Axboe
2009-05-26 9:33 ` [PATCH 06/12] writeback: separate the flushing state/task from the bdi Jens Axboe
2009-05-25 7:30 [PATCH 0/12] Per-bdi writeback flusher threads #5 Jens Axboe
2009-05-25 7:30 ` [PATCH 06/12] writeback: separate the flushing state/task from the bdi Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090525103623.GU11363@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.