From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
alsa-devel@alsa-project.org, Eric Miao <eric.miao@marvell.com>,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH 1/2] pxa2xx-ac97-lib: move set_resetgpio to pxa27x.c
Date: Mon, 25 May 2009 11:47:20 +0100 [thread overview]
Message-ID: <20090525104720.GA6567@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <f17812d70905250321y4b914bc8r24527b51ff0531e8@mail.gmail.com>
On Mon, May 25, 2009 at 06:21:40PM +0800, Eric Miao wrote:
> there are two other ways out from my POV:
> 2. or having something like IrDA, i.e. platform specific hooks to make
> the driver code generic
> I personally prefer way 2) but don't have time for a clean solution yet,
> maybe you can help take a look into this. That would be nice.
For 2 we should probably just move all the reset implementations into
the CPU code and then either have a function to select the
implementation or keep using the current code but move the functions it
references.
I don't really mind how this is done so long as you guys are happy with
it, though if we're going to move the pxa27x functions only a better
commit log explaining the issue with the MFP API would be nice.
prev parent reply other threads:[~2009-05-25 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 9:20 [PATCH 1/2] pxa2xx-ac97-lib: move set_resetgpio to pxa27x.c Dmitry Eremin-Solenikov
2009-05-25 9:20 ` [PATCH 2/2] pxa2xx: make pxa2xx_ac97_reset use MFP Dmitry Eremin-Solenikov
2009-05-25 10:21 ` [PATCH 1/2] pxa2xx-ac97-lib: move set_resetgpio to pxa27x.c Eric Miao
2009-05-25 10:47 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090525104720.GA6567@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dbaryshkov@gmail.com \
--cc=eric.miao@marvell.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.