From: Paul Brook <paul@codesourcery.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Avi Kivity <avi@redhat.com>,
qemu-devel@nongnu.org, Carsten Otte <cotte@de.ibm.com>,
kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
virtualization@lists.linux-foundation.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [PATCH] qemu: virtio save/load bindings
Date: Tue, 26 May 2009 11:20:29 +0100 [thread overview]
Message-ID: <200905261120.30344.paul@codesourcery.com> (raw)
In-Reply-To: <4A1BA998.8040803@codemonkey.ws>
> > - /* FIXME: load/save binding. */
> > - //pci_device_save(&vdev->pci_dev, f);
> > - //msix_save(&vdev->pci_dev, f);
>
> qdev regressed save/restore? What else is broken right now from the
> qdev commit?
>
> I'm beginning to think committing in the state it was in was a mistake.
> Paul, can you put together a TODO so that we know all of the things that
> have regressed so we can get things back into shape?
Sorry, this one apparently slipped past. I#'d intended to fix it, but
apparently never ported that bit of the patch.
Paul
next prev parent reply other threads:[~2009-05-26 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 13:34 [PATCH] qemu: virtio save/load bindings Michael S. Tsirkin
2009-05-26 8:34 ` Anthony Liguori
2009-05-26 10:20 ` Paul Brook [this message]
2009-05-26 10:20 ` Paul Brook
2009-06-03 10:31 ` [Qemu-devel] " Avi Kivity
2009-06-03 10:31 ` Avi Kivity
2009-05-26 8:34 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2009-05-25 13:34 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905261120.30344.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.