All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] usb: r8a66597-hcd: use platform_data instead of module_param
Date: Tue, 26 May 2009 12:38:07 +0000	[thread overview]
Message-ID: <20090526123806.GA17356@linux-sh.org> (raw)
In-Reply-To: <4A1BB552.3020909@renesas.com>

On Tue, May 26, 2009 at 06:24:34PM +0900, Yoshihiro Shimoda wrote:
> CPU/board specific parameters (PLL clock, vif etc...) can be set
> by platform_data instead of module_param.
> 
> v2: remove irq_sense member in platform_data because it can OR in
>     IRQF_TRIGGER_LOW or IRQF_TRIGGER_FALLING against IORESOURCE_IRQ in
>     the struct resource.
> 
> Signed-off-by: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>

Looks better!

Reviewed-by: Paul Mundt <lethal@linux-sh.org>

  reply	other threads:[~2009-05-26 12:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-26  9:24 [PATCH v2] usb: r8a66597-hcd: use platform_data instead of module_param Yoshihiro Shimoda
2009-05-26 12:38 ` Paul Mundt [this message]
2009-05-27  0:25 ` [PATCH v2] usb: r8a66597-hcd: use platform_data instead of Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090526123806.GA17356@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.