From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] drop xfs_version.h
Date: Tue, 26 May 2009 15:51:40 -0400 [thread overview]
Message-ID: <20090526195140.GA4368@infradead.org> (raw)
In-Reply-To: <4A1C449E.7070004@sandeen.net>
On Tue, May 26, 2009 at 02:35:58PM -0500, Eric Sandeen wrote:
> xfs_version.h is about 30 lines for the benefit of
> one single define, which seems a bit silly.
>
> Just drop the file and hardcode "SGI XFS" the 2
> places it's used.
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> - printk(KERN_INFO XFS_VERSION_STRING " with "
> + printk(KERN_INFO "SGI XFS with "
> XFS_BUILD_OPTIONS " enabled\n");
To prove that I can nitpick about even the most trivial patch:
shouldn't this be merged into a single line now? :)
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-05-26 19:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 19:35 [PATCH] drop xfs_version.h Eric Sandeen
2009-05-26 19:51 ` Christoph Hellwig [this message]
2009-05-26 20:00 ` [PATCH V2] " Eric Sandeen
2009-05-26 20:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526195140.GA4368@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.