From: Greg KH <greg@kroah.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: GeunSik Lim <leemgs1@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
trivial@kernel.org, balagi@justmail.de, bgamari@gmail.com,
Ingo Molnar <mingo@elte.hu>,
inaky.perez-gonzalez@intel.com
Subject: Re: [RFC PATCH]debugfs:Fix terminology inconsistency of dir name to mount debugfs filesystem.
Date: Tue, 26 May 2009 13:54:14 -0700 [thread overview]
Message-ID: <20090526205414.GA26016@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0905261642130.26705@gandalf.stny.rr.com>
On Tue, May 26, 2009 at 04:44:49PM -0400, Steven Rostedt wrote:
>
> On Tue, 26 May 2009, GeunSik Lim wrote:
>
> >
> >
> > Hi all,
> >
> > I want to hear your opinions about this proposal for consistency of
> > mount directory to mount debugfs filesystem that need by ftrace infrastructure.
> > Um... I appended "RFC" word in the subject because this mail is my proposal just.
> >
> >
> > commit 1766a83645706100b1829bb422f852ec757c6f4b
> > Author: GeunSik,Lim <leemgs1@gmail.com>
> > Date: Tue May 26 13:49:23 2009 +0900
> >
> > Fix terminology inconsistency of dir name to mount debugfs filesystem.
> >
> > Many developers use "/debug/" directory name to mount debugfs filesystem
> > for ftrace according to ./Documentation/tracers/ftrace.txt file.
> >
> > But, two directory names(ex:/debug/, /debugfs/) is existed in kernel source
> > like ftrace, DRM, Wireless, Network[sky2]files to mount debugfs filesystem.
> > I think that we don't have to select either "/debug/" directory name or
> > "/debugfs/" directory name for terminology consistency.
> >
> > debugfs means debug filesystem for debugging easy to use by greg kroah
> > hartman. "/debug/" name is suitable as directory name of debugfs for
> > tracing using ftrace like "/sys/" of sysfs(system filesystem).
> > -debugfs related reference: http://lwn.net/Articles/115405/
> >
> > Fix inconsistency of directory name according to duplicated expression
> > to mount debugfs.
> >
> > Signed-off-by: GeunSik Lim <geunsik.lim@samsung.com>
>
> I'm guilty of using both /debug and /debugfs in comments. In practice, I
> only use /debug.
>
> But...
>
> The filesystem Nazi's out there will argue that the proper place to mount
> the debugfs filesystem is /sys/kernel/debug. I personally find that
> location annoying.
Why?
When I created debugfs, I was told that I had to pick a place to mount
it so that everyone could write scripts that "knew" where it would be.
So we picked /sys/kernel/debug/ and the code creates the mount point to
put it there. Now distros actually mount debugfs at that location.
So, now you don't like this? After it's become a standard? Ick.
Becides, /debug/ is pretty presumptious, it's as if debugging the kernel
is a system-wide thing :)
So please, don't use /debug/ use the standard, defined, and ACTUALLY
USED BY DISTROS TODAY mount point of /sys/kernel/debug/
If you want to create your own symlink from /debug/ to that location to
make it easier to type, feel free, but do not hard code any scripts to
use that location, or they are going to break.
thanks,
greg k-h
next prev parent reply other threads:[~2009-05-26 21:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 5:19 [RFC PATCH]debugfs:Fix terminology inconsistency of dir name to mount debugfs filesystem GeunSik Lim
2009-05-26 19:50 ` Iñaky Pérez-González
2009-05-26 20:44 ` Steven Rostedt
2009-05-26 20:54 ` Greg KH [this message]
2009-05-26 21:15 ` Steven Rostedt
2009-05-26 22:14 ` Greg KH
2009-05-27 2:24 ` GeunSik Lim
2009-05-27 2:38 ` Steven Rostedt
2009-05-27 5:30 ` GeunSik Lim
2009-05-27 5:50 ` Jaswinder Singh Rajput
2009-05-27 18:22 ` Steven Rostedt
2009-05-27 19:13 ` Greg KH
2009-05-28 13:45 ` Steven Rostedt
2009-05-28 21:41 ` Greg KH
2009-05-28 22:17 ` GeunSik Lim
2009-05-29 16:05 ` [RFC V2 " GeunSik Lim
2009-05-29 16:27 ` Steven Rostedt
2009-05-29 16:33 ` Steven Rostedt
2009-05-29 16:35 ` Steven Rostedt
2009-05-29 16:48 ` Steven Rostedt
2009-05-30 1:43 ` GeunSik Lim
2009-05-30 2:28 ` Steven Rostedt
2009-05-30 9:38 ` GeunSik Lim
2009-05-30 11:21 ` GeunSik Lim
2009-05-30 13:44 ` Steven Rostedt
2009-05-30 15:17 ` GeunSik Lim
2009-05-30 13:36 ` Steven Rostedt
2009-05-31 3:04 ` [RFC V3 " GeunSik Lim
2009-06-02 6:01 ` [PATCH V1]debugfs:Fix " GeunSik Lim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526205414.GA26016@kroah.com \
--to=greg@kroah.com \
--cc=balagi@justmail.de \
--cc=bgamari@gmail.com \
--cc=inaky.perez-gonzalez@intel.com \
--cc=leemgs1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.