All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Q: do_notify_parent/do_notify_parent_cldstop && info.si_xtime
Date: Tue, 26 May 2009 23:13:06 +0200	[thread overview]
Message-ID: <20090526211306.GA7065@redhat.com> (raw)

do_notify_parent() reports .si_Xtime = tsk->Xtime + signal->Xtime,
but do_notify_parent_cldstop() uses .si_Xtime =  tsk->Xtime.

Is this right?

Yes, tsk->Xtime + signal->Xtime does not make much sense for
do_notify_parent_cldstop(), but reporting group_leader->Xtime
(if not traced) doesn't look very right too. IOW, perhaps we
need thread_group_cputime() here?

Ole.


             reply	other threads:[~2009-05-26 21:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-26 21:13 Oleg Nesterov [this message]
2009-05-27  1:40 ` Q: do_notify_parent/do_notify_parent_cldstop && info.si_xtime Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090526211306.GA7065@redhat.com \
    --to=oleg@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.