Re: [PATCH] firmware: Allocate firmware id dynamically

[Samuel Ortiz <sameo@linux.intel.com>]

Hi Stephen,

On Wed, May 27, 2009 at 11:57:48AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Tue, 26 May 2009 13:23:51 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > > > Please note that we have to keep the FIRMWARE_NAME_MAX definition around as
> > > > some drivers rely on it.
> > > 
> > > I think the 6 files should be converted, and FIRMWARE_NAME_MAX
> > > removed, otherwise people will keep copying that crap around.
> > > 
> > >   drivers/pcmcia/ds.c
> > >   drivers/usb/atm/ueagle-atm.c
> > >   drivers/net/wireless/libertas/if_usb.c
> > >   drivers/net/wireless/libertas/if_spi.c
> > >   drivers/media/dvb/dvb-usb/dvb-usb.h
> > >   drivers/media/common/tuners/tuner-xc2028.c
> > 
> > Yep.
> 
> $ git grep -l -w FIRMWARE_NAME_MAX next-20090526 
> next-20090526:drivers/base/firmware_class.c
> next-20090526:drivers/media/common/tuners/tuner-xc2028.c
> next-20090526:drivers/media/dvb/dvb-usb/dvb-usb.h
> next-20090526:drivers/net/wireless/libertas/if_spi.c
> next-20090526:drivers/net/wireless/libertas/if_usb.c
> next-20090526:drivers/net/wireless/p54/p54usb.c
> next-20090526:drivers/pcmcia/ds.c
> next-20090526:drivers/usb/atm/ueagle-atm.c
> next-20090526:include/linux/firmware.h
All of those have been taken care of by my last patch set, see:
http://lkml.org/lkml/2009/5/26/518

The p54usb one has been sent to John and linux-wireless as it's coming from
wireless-testing.


> next-20090526:samples/firmware_class/firmware_sample_firmware_class.c
Do I really need to fix this one too ?

Cheers,
Samuel.
-- 
Intel Open Source Technology Centre
http://oss.intel.com/