From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761159AbZE0LvM (ORCPT ); Wed, 27 May 2009 07:51:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756293AbZE0Lus (ORCPT ); Wed, 27 May 2009 07:50:48 -0400 Received: from mx1.emlix.com ([193.175.82.87]:55780 "EHLO mx1.emlix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756389AbZE0Luq (ORCPT ); Wed, 27 May 2009 07:50:46 -0400 Date: Wed, 27 May 2009 13:49:56 +0200 From: Johannes Weiner To: Andrew Morton Cc: Paul Mundt , os@emlix.com, dhowells@redhat.com, rmk@arm.linux.org.uk, cooloney@kernel.org, geert@linux-m68k.org, vapier.adi@gmail.com, gerg@uclinux.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -v3] flat: fix data sections alignment Message-ID: <20090527114955.GA23343@emlix.com> References: <20090310073350.GH10393@linux-sh.org> <20090402135343.d18d17a5.akpm@linux-foundation.org> <20090409142553.GA3330@emlix.com> <20090505140847.GB25409@emlix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090505140847.GB25409@emlix.com> User-Agent: Mutt/1.5.18 (2008-05-17) Organization: emlix gmbh, Goettingen, Germany Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 05, 2009 at 04:08:47PM +0200, Johannes Weiner wrote: > On Thu, Apr 09, 2009 at 04:25:53PM +0200, Johannes Weiner wrote: > > On Thu, Apr 02, 2009 at 01:53:43PM -0700, Andrew Morton wrote: > > > On Tue, 10 Mar 2009 16:33:50 +0900 > > > Paul Mundt wrote: > > > > > > > On Thu, Mar 05, 2009 at 06:00:59PM +0100, Oskar Schirmer wrote: > > > > > The flat loader uses an architecture's flat_stack_align() to align the > > > > > stack but assumes word-alignment is enough for the data sections. > > > > > > > > > > However, on the Xtensa S6000 we have registers up to 128bit width > > > > > which can be used from userspace and therefor need userspace stack and > > > > > data-section alignment of at least this size. > > > > > > > > > > This patch drops flat_stack_align() and uses the same alignment that > > > > > is required for slab caches, ARCH_SLAB_MINALIGN, or wordsize if it's > > > > > not defined by the architecture. > > > > > > > > > > It also fixes m32r which was obviously kaput, aligning an > > > > > uninitialized stack entry instead of the stack pointer. > > > > > > > > > > Signed-off-by: Oskar Schirmer > > > > > Signed-off-by: Johannes Weiner > > > > > Cc: David Howells > > > > > Cc: Russell King > > > > > Cc: Bryan Wu > > > > > Cc: Geert Uytterhoeven > > > > > Cc: Paul Mundt > > > > > Cc: Greg Ungerer > > > > > Cc: Mike Frysinger > > > > > > > > The updated version looks ok to me anyways, and it's certainly an > > > > improvement over defining the same alignment requirements all over the > > > > place. > > > > > > > > Acked-by: Paul Mundt > > > > > > Quite a few people expressed quite a few reservations over v2. > > > > > > Are we all OK with a v3 merge? > > > > Paul and Mike had complaints. Paul acked the last revision. Mike? > > We need this for upstream to compile on our configuration. > > Can we get this merged? Nobody complained. What are the plans on this now? I assume it drowned in other changes... Is it too late to get this in .30 now?