From: Matthew Wilcox <matthew@wil.cx>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] PCI: Quirk for hwmon access on MSI MS-7031 board
Date: Wed, 27 May 2009 16:38:37 +0000 [thread overview]
Message-ID: <20090527163837.GI5816@parisc-linux.org> (raw)
In-Reply-To: <20090525220652.04c2468f@hyperion.delvare>
On Wed, May 27, 2009 at 06:30:05PM +0200, Jean Delvare wrote:
> > > +#if defined CONFIG_X86 && (defined CONFIG_HWMON || defined CONFIG_HWMON_MODULE)
> >
> > I don't like this. It goes against the principle that enabling a module
> > shouldn't cause the base kernel to get rebuilt. Is there a reason that
> > the hardware monitoring code can't contain this quirk instead of the
> > generic PCI code?
>
> No reason other than the fact that putting it in pci/quirks.c was
> easier. I can certainly move the quirk to hwmon/hwmon.c, but as far as
> I can see you have the exact same problem there: enabling or disabling
> PCI support will cause the base hwmon module to be rebuilt. If hwmon is
> built into the kernel then you have to relink the kernel.
Trust me, if you enable or disable PCI support, you already have to
relink the kernel ;-)
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2009-05-27 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 20:06 [lm-sensors] PCI: Quirk for hwmon access on MSI MS-7031 board Jean Delvare
2009-05-27 15:44 ` Matthew Wilcox
2009-05-27 16:30 ` Jean Delvare
2009-05-27 16:38 ` Matthew Wilcox [this message]
2009-05-31 18:13 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090527163837.GI5816@parisc-linux.org \
--to=matthew@wil.cx \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.