From: Andrew Morton <akpm@linux-foundation.org>
To: Pierre Ossman <pierre@ossman.eu>
Cc: dsaxena@plexity.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MMC: Add 400ms to CAFE SD controller resume path
Date: Thu, 28 May 2009 01:36:29 -0700 [thread overview]
Message-ID: <20090528013629.0173522b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090522135150.7e0716d6@mjolnir.ossman.eu>
On Fri, 22 May 2009 13:51:50 +0200 Pierre Ossman <pierre@ossman.eu> wrote:
> On Wed, 13 May 2009 20:05:56 +0000
> Deepak Saxena <dsaxena@plexity.net> wrote:
>
> >
> > The CAFE SD controller takes a long time to completely resume
> > and w/o this patch, we do not redetect an existing card but
> > instead detect it as a new one. Even with MMC_UNSAFE_RESUME
> > enabled, this leads to the partition table on the device being
> > wiped out.
> >
> > See http://dev.laptop.org/ticket/6532 for gory details.
hm, this sounds like a fairly serious problem, but the patch is nearly
a year old.
> > Signed-off-by: Deepak Saxena <dsaxena@laptop.org>
> >
>
> Reading through that report, I don't believe you properly worked around
> the bug. You only avoid bug 1339, but that's only mildly related.
>
> What this workaround does is to make sure that MMC_UNSAFE_RESUME
> actually works. But if you change cards during suspend, the VFS bug
> should reappear and you'll corrupt the partition table.
What do you think the VFS did wrong here?
> And as for 1339, has there been any more work done on why this problem
> doesn't appear in OFW? I'd be a lot happier if we could make things
> work without artificial delays.
next prev parent reply other threads:[~2009-05-28 8:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 20:05 [PATCH] MMC: Add 400ms to CAFE SD controller resume path Deepak Saxena
2009-05-22 11:51 ` Pierre Ossman
2009-05-28 8:36 ` Andrew Morton [this message]
2009-05-28 8:48 ` Pierre Ossman
2009-06-04 23:33 ` Deepak Saxena
2009-06-13 10:34 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090528013629.0173522b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre@ossman.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.