From: Inaky Perez-Gonzalez <inaky@linux.intel.com>
To: wimax@linuxwimax.org
Cc: Stephen Hemminger <shemminger@vyatta.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
Subject: Re: [patch 2.6.31 08/10] wimax: Add netlink interface to get device state
Date: Thu, 28 May 2009 09:16:21 -0700 [thread overview]
Message-ID: <200905280916.23022.inaky@linux.intel.com> (raw)
In-Reply-To: <20090527182157.48a3f4b0@nehalam>
On Wednesday 27 May 2009, Stephen Hemminger wrote:
> On Wed, 27 May 2009 18:05:13 -0700
>
> Inaky Perez-Gonzalez <inaky@linux.intel.com> wrote:
> > From: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
> >
> > wimax connection manager / daemon has to know what is current
> > state of the device. Previously it was only possible to get
> > notification whet state has changed.
> >
> > ...
> > ...
> > > > diff --git a/include/linux/wimax.h b/include/linux/wimax.h
> > index c89de7f..c750f42 100644
> > --- a/include/linux/wimax.h
> > +++ b/include/linux/wimax.h
> > @@ -77,6 +77,7 @@ enum {
> > WIMAX_GNL_OP_MSG_TO_USER, /* Kernel to user message */
> > WIMAX_GNL_OP_RFKILL, /* Run wimax_rfkill() */
> > WIMAX_GNL_OP_RESET, /* Run wimax_rfkill() */
> > + WIMAX_GNL_OP_STATE_GET, /* Request for current state */
> > WIMAX_GNL_RE_STATE_CHANGE, /* Report: status change */
> > };
>
> Won't adding new element in middle of list break existing ABI?
Actually that's an extremely good point that I missed completely.
Thanks for catching it.
David, I'll submit an extra commit for correcting that point.
--
Inaky
next prev parent reply other threads:[~2009-05-28 16:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 1:05 [patch 2.6.31 00/10] WiMAX pull request Inaky Perez-Gonzalez
2009-05-28 1:05 ` [patch 2.6.31 01/10] wimax/i2400m: generate fake source MAC address with random_ether_addr() Inaky Perez-Gonzalez
2009-05-28 1:05 ` [patch 2.6.31 02/10] wimax/i2400m: trace commands sent from user space on the "echo" pipe Inaky Perez-Gonzalez
2009-05-28 1:05 ` [patch 2.6.31 03/10] wimax/i2400m: allow kernel commands to device to be logged too Inaky Perez-Gonzalez
2009-05-28 1:05 ` [patch 2.6.31 04/10] wimax/i2400m: factor out 'state report's TLV handling to a function Inaky Perez-Gonzalez
2009-05-28 1:05 ` [patch 2.6.31 05/10] wimax/i2400m: remove redundant readiness checks from i2400m_report_tlv_*() Inaky Perez-Gonzalez
2009-05-28 1:05 ` [patch 2.6.31 06/10] wimax: document why wimax_msg_*() operations can be used in any state Inaky Perez-Gonzalez
2009-05-28 1:05 ` [patch 2.6.31 07/10] wimax/i2400m: sdio: set the block size before enabling the function Inaky Perez-Gonzalez
2009-05-28 1:05 ` [patch 2.6.31 08/10] wimax: Add netlink interface to get device state Inaky Perez-Gonzalez
2009-05-28 1:21 ` Stephen Hemminger
2009-05-28 16:16 ` Inaky Perez-Gonzalez [this message]
2009-05-28 22:06 ` David Miller
2009-05-28 22:09 ` Inaky Perez-Gonzalez
2009-05-28 1:05 ` [patch 2.6.31 09/10] wimax/i2400m: usb: fix device reset on autosuspend while not yet idle Inaky Perez-Gonzalez
2009-05-28 1:05 ` [patch 2.6.31 10/10] wimax: a new API call was added, increment minor protocol version number Inaky Perez-Gonzalez
-- strict thread matches above, loose matches on Subject: below --
2009-05-29 1:12 [patch 2.6.31 00/10] WiMAX pull request (v2) Inaky Perez-Gonzalez
2009-05-29 1:12 ` [patch 2.6.31 08/10] wimax: Add netlink interface to get device state Inaky Perez-Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905280916.23022.inaky@linux.intel.com \
--to=inaky@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=paulius.zaleckas@teltonika.lt \
--cc=shemminger@vyatta.com \
--cc=wimax@linuxwimax.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.