From: David Aguilar <davvid@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: git@vger.kernel.org, gitster@pobox.com, markus.heidelberg@web.de,
jnareb@gmail.com
Subject: Re: [PATCH v2 1/2] compat: add a mkstemps() compatibility function
Date: Thu, 28 May 2009 02:31:53 -0700 [thread overview]
Message-ID: <20090528093152.GA12566@gmail.com> (raw)
In-Reply-To: <4A1E3834.3020502@viscovery.net>
On Thu, May 28, 2009 at 09:07:32AM +0200, Johannes Sixt wrote:
> David Aguilar schrieb:
>
> You should not include "random" system headers, nor has mkstemps any
> business deciding whether files are opened in binary mode. We are not
> using O_BINARY anywhere else (except in compat/mingw.c). With the patch
> below squashed in (I hope it won't be wrapped) you can add:
>
> Tested-by: Johannes Sixt <j6t@kdbg.org> (Windows)
>
> to both your patches. And, yes, I like them :-)
>
> -- Hannes
Thanks.
I'll squash these in and resend 1/2 in a moment.
--
David
prev parent reply other threads:[~2009-05-28 9:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 6:11 [PATCH v2 1/2] compat: add a mkstemps() compatibility function David Aguilar
2009-05-28 6:11 ` [PATCH v2 2/2] diff: generate prettier filenames when using GIT_EXTERNAL_DIFF David Aguilar
2009-05-28 17:44 ` Jeff King
2009-05-28 21:30 ` David Aguilar
2009-05-28 22:06 ` Jeff King
2009-05-28 7:07 ` [PATCH v2 1/2] compat: add a mkstemps() compatibility function Johannes Sixt
2009-05-28 9:31 ` David Aguilar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090528093152.GA12566@gmail.com \
--to=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=jnareb@gmail.com \
--cc=markus.heidelberg@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.