From: Florian Fainelli <florian@openwrt.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] rb532: fix irq number check in rb532_set_type
Date: Thu, 28 May 2009 12:37:54 +0200 [thread overview]
Message-ID: <200905281237.55899.florian@openwrt.org> (raw)
In-Reply-To: <20090527131535.GC7755@linux-mips.org>
Le Wednesday 27 May 2009 15:15:35 Ralf Baechle, vous avez écrit :
> On Wed, May 27, 2009 at 02:14:06PM +0200, Florian Fainelli wrote:
> > We only have 14 GPIO interrupt sources numbered
> > from 0 to 13. Therefore the check against irq_nr
> > in rb532_set_type is off-by-one. This fixes a mistake
> > introduced by commit 1b4f571632ffb0caa4170d886694f2555c0d9a4b.
>
> Thanks; I've folded this patch into your old patch.
Thank you !
>
> A note on commit IDs on the -queue tree. The -queue tree is really
> maintained in quilt and respun every time I change any of the commits
> on it. This means the commit IDs will also change, so they should be
> considered volatile.
I will take that into account next time, thanks for fixing this.
--
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------
prev parent reply other threads:[~2009-05-28 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 12:14 [PATCH] rb532: fix irq number check in rb532_set_type Florian Fainelli
2009-05-27 13:15 ` Ralf Baechle
2009-05-28 10:37 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905281237.55899.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.