All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core : fix request_firmware_nowait
Date: Thu, 28 May 2009 13:14:50 -0700	[thread overview]
Message-ID: <20090528201450.GA4043@kroah.com> (raw)
In-Reply-To: <d82e647a0905220826p378f6bb4vac9150343b5c3622@mail.gmail.com>

On Fri, May 22, 2009 at 11:26:16PM +0800, Ming Lei wrote:
> 2009/5/22 Alan Cox <alan@lxorguk.ukuu.org.uk>:
> > On Fri, 22 May 2009 23:06:27 +0800
> > tom.leiming@gmail.com wrote:
> >
> >> From: Ming Lei <tom.leiming@gmail.com>
> >>
> >> request_firmware_nowait declares it can be called in non-sleep contexts,
> >> but kthead_run which is called by request_firmware_nowait may sleep.
> >
> > Does anyone actually need to call it in a non-sleeping context or can the
> > documentation simply be fixed instead to avoid all the extra complexity ?
> >
> 
> It seems no one calls it in a non-sleeping context now, but we can provide it
> without much extra complexity, IMHO.  Also someone has complained it :
> 
>       http://marc.info/?t=124022846400003&r=1&w=2

That was 3 years ago :)

I say just fix the documentation.

thanks,

greg k-h

  reply	other threads:[~2009-05-28 20:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-22 15:06 [PATCH] driver core : fix request_firmware_nowait tom.leiming
2009-05-22 15:10 ` Alan Cox
2009-05-22 15:26   ` Ming Lei
2009-05-28 20:14     ` Greg KH [this message]
2009-05-29  1:24       ` Ming Lei
2009-05-29  1:43         ` Greg KH
2009-05-29  3:33           ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090528201450.GA4043@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.