From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760560AbZE2SK0 (ORCPT ); Fri, 29 May 2009 14:10:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753349AbZE2SKO (ORCPT ); Fri, 29 May 2009 14:10:14 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:42446 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752727AbZE2SKN (ORCPT ); Fri, 29 May 2009 14:10:13 -0400 From: "Rafael J. Wysocki" To: Jan Scholz Subject: Re: [regression, bisected] adb trackpad disappears after suspend to ram Date: Fri, 29 May 2009 20:10:09 +0200 User-Agent: KMail/1.11.2 (Linux/2.6.30-rc6-rjw; KDE/4.2.3; x86_64; ; ) Cc: Benjamin Herrenschmidt , Paul Mackerras , Ingo Molnar , linux-kernel@vger.kernel.org, Adrian Bunk , pm list References: <878wkl6vce.fsf@scholz.fias.uni-frankfurt.de> <1243549422.17903.10.camel@pasglop> <87tz34n97p.fsf@scholz.fias.uni-frankfurt.de> In-Reply-To: <87tz34n97p.fsf@scholz.fias.uni-frankfurt.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905292010.10615.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 29 May 2009, Jan Scholz wrote: > Benjamin Herrenschmidt writes: > > >> We are too late in the cycle to revert this commit and it really is needed to > >> fix a more serious issue. Nevertheless knowing that it caused the problem to > >> appear on your system is also important. > >> > >> Ben, do you have an idea what may be going on here? Does __disable_irq() mask > >> the interrupt on this platform? > > > > I suppose so :-) I'll have to check what's going on, it's not > > immediately clear to me. > > > > Cheers, > > Ben. > > > >> > >> I'd like to see a boot log, preferably containing a suspend-resume in which > >> the problem was reproduced. > > Here is a log from booting, through several suspend cycles, until the > trackpad disappeared. The first few suspends were done while X was > running but from the console. As you can tell from lines like > May 28 23:51:26 [kernel] adb devices: [2]: 2 c4 [3]: 3 1 [7]: 7 1f > the trackpad was still present. The last suspend was done from within X, > here the trackpad did not make it. > May 28 23:58:09 [kernel] adb devices: [2]: 2 c4 [7]: 7 1f > However, there have been cases, although not in this log, were the > trackpad has been alive even when suspending from within X. This means the problem is probably timing-related. Can you please try to comment out suspend_device_irqs() and resume_device_irqs() in drivers/base/power/main.c and see if that changes anything? It's not entirely safe (well, that's why the calls are there after all), but hopefully the box won't hang during this test. Best, Rafael