All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Fredrik Arnerup" <fredrik.arnerup@edgeware.tv>
Cc: <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org
Subject: Re: IFF_LOWER_UP does not fit in ifr_flags
Date: Fri, 29 May 2009 20:50:28 -0700	[thread overview]
Message-ID: <20090529205028.3e01786b.akpm@linux-foundation.org> (raw)
In-Reply-To: <89A39FC0957640879F8975880836CF91@edgeware.tv>

On Thu, 28 May 2009 14:59:05 +0200 "Fredrik Arnerup" <fredrik.arnerup@edgeware.tv> wrote:

> Documentation/networking/operstates.txt (and netdevice(7)) claims that
> the flags IFF_LOWER_UP, IFF_DORMANT and IFF_ECHO can be read from user space
> using ioctl() with SIOCGIFFLAGS. Looking in include/linux/if.h however,
> the flags are returned in a struct ifreq in the field ifr_flags which
> is declared as a short, while the flags are defined as:
> 
> #define IFF_LOWER_UP    0x10000         /* driver signals L1 up         */
> #define IFF_DORMANT     0x20000         /* driver signals dormant       */
> #define IFF_ECHO        0x40000         /* echo sent packets            */
> 
> Those aren't shorts, are they? In net/core/dev.c dev_get_flags() returns
> an unsigned which is assigned to ifr_flags directly.
> 
> Looked at linux/kernel/git/stable/linux-2.6.29.y.git.
> CC me please.
> 

(cc netdev)

  reply	other threads:[~2009-05-30  3:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-28 12:59 IFF_LOWER_UP does not fit in ifr_flags Fredrik Arnerup
2009-05-30  3:50 ` Andrew Morton [this message]
2009-06-05 16:24   ` [PATCH] " John Dykstra
2009-06-12  3:57     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090529205028.3e01786b.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=fredrik.arnerup@edgeware.tv \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.