Re: Fwd: [PATCH] gfxpayload

[Robert Millan <rmh@aybabtu.com>]

On Sat, May 30, 2009 at 05:23:18PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> On Sun, May 17, 2009 at 10:36 PM, Robert Millan <rmh@aybabtu.com> wrote:
> >
> > Hi,
> >
> > On Sun, May 17, 2009 at 04:34:16PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> >>  #ifndef GRUB_ASSUME_LINUX_HAS_FB_SUPPORT
> >> -#define GRUB_ASSUME_LINUX_HAS_FB_SUPPORT 0
> >> +#define DEFAULT_VIDEO_MODE "text"
> >> +#else
> >> +#define DEFAULT_VIDEO_MODE "keep"
> >>  #endif
> >
> > As discussed on IRC, this "keep" option seems unnecessary;  it just means
> > "do nothing" so we may as well #ifdef the code out.
> It may be necessary in future for linux loader to be able to check if
> current mode is acceptable for linux (e.g. vnc is not). xnu code does
> this (text mode isn't acceptable). But for now calling with keep can
> be put in ifdef..endif

Maybe, but there's no point in some part of GRUB telling another routine
"please do nothing, leave things as they are" when it could just not call
it instead.  It just wastes execution time.

> >> +             grub_error (GRUB_ERR_OUT_OF_MEMORY,
> >> +                         "couldn't allocate temporary storage");
> >> +             goto fail;
> >> +           }
> >
> > Doesn't grub_malloc set this errno / errmsg already?
> >
> It says "out of memory" but I guess it should be clear enough.

If it's not, it should be fixed in kern/mm.c.  There's nothing specific to
linux.c in this problem.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."