Re: [PATCH] input: add support for generic GPIO-based matrix keypad

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Sunday 31 May 2009 07:29:08 Eric Miao wrote:
> On Sun, May 31, 2009 at 10:20 PM, Russell King - ARM Linux
>
> <linux@arm.linux.org.uk> wrote:
> > On Sun, May 31, 2009 at 10:12:25PM +0800, Eric Miao wrote:
> >> +static void __devinit build_keycodes(struct matrix_keypad *keypad)
> >> +{
> >> +     struct matrix_keypad_platform_data *pdata = keypad->pdata;
> >> +     struct input_dev *input_dev = keypad->input_dev;
> >> +     uint32_t *key;
> >> +     int i;
> >> +
> >> +     keypad->keycodes = kzalloc(MATRIX_MAX_KEYS * sizeof(int),
> >> GFP_KERNEL);
> >
> > This doesn't check for failure...
>
> Oops, updated (together with the release) as below:

Eric, could you please send me this patch as a diff to the original
one you sent?

Thanks a lot.

-- 
Dmitry