Re: [PATCH] i2c: driver for the Synopsys DesignWare I2C controller

[Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>]

Hi Linus,

On Sun, May 31, 2009 at 08:47:31PM +0200, Linus Walleij wrote:
> 2009/5/31 Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>:
> > On Thu, May 28, 2009 at 09:32:37AM +0200, Linus Walleij wrote:
> >> 2009/5/28 Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>:
> >>
> >> >> > +static int dw_i2c_probe(struct platform_device *pdev)
> >> >>
> >> >> Can you tag this with __init?
> >> >
> >> > OK. __devinit is probably better.
> >>
> >> I don't think any platform_device tagged with __devinit is
> >> correct really, platform_device:s cannot  be hotplugged that's
> >> against the definition of a platform_device.
> >
> > Doesn't this __devinit have something to do with the ability to compile the
> > driver as a module (as is the case here)? See for example
> > drivers/watchdog/omap_wdt.c and commit
> > 0e3912c75f42986c17d955542247bf04c6eef738
> 
> ...
>
> In practice this means that if you device is _NOT_ hot-pluggable, the
> kernel will still nevertheless keep all the code in __devinit and
> __devexit around which means that __devinit code cannot be
> free:ed after init and it increases the footprint of your kernel for no
> good reason.

Thanks for your detailed explanation. I'll go for __init then.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -