From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhai, Edwin" Subject: Re: [PATCH] xend: Update info['platform']['pci'] Date: Mon, 1 Jun 2009 14:01:58 +0800 Message-ID: <20090601060158.GA8483@edwin-srv.sh.intel.com> References: <78C9DF622C5003kanno.masaki@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <78C9DF622C5003kanno.masaki@jp.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Masaki Kanno Cc: "xen-devel@lists.xensource.com" , "Zhai, Edwin" , "horms@verge.net.au" List-Id: xen-devel@lists.xenproject.org Masaki, How about removing the 'pci' config from the info['platform']? We already have the info['devices'] to kept the pci/vif/disk config, so duplicated info in ['platform']['pci'] would cause synchronization troubles. There are only several places using info['platform']['pci'], so take place of them with _getDeviceInfo_pci('0') should be okay. Thanks, On Thu, May 28, 2009 at 03:01:50PM +0800, Masaki Kanno wrote: > Hi, > > This patch updates info['platform']['pci'] for PCI devices assignment > to domains. > > When a domain is started, xend confirms by using xc.test_assign_device > whether PCI devices can be assigned to the domain. > For the confirmation, info['platform']['pci'] must be an appropriate > value. However, info['platform']['pci'] may be not appropriate. > Because info['platform']['pci'] isn't almost always updated even if > the PCI device configuration of the domain was changed by using > xm pci-attach/detach. > This patch updates info['platform']['pci'] to the appropriate value > when domains are started. > > Cc: Simon Horman > Signed-off-by: Masaki Kanno > > Best regards, > Kan > Content-Description: ATT00001.txt > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel -- best rgds, edwin