From: Michael Buesch <mb@bu3sch.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: parport_pc: Fix subscription bugs
Date: Mon, 1 Jun 2009 11:27:03 +0200 [thread overview]
Message-ID: <200906011127.03296.mb@bu3sch.de> (raw)
In-Reply-To: <20090601101440.203c000a@lxorguk.ukuu.org.uk>
On Monday 01 June 2009 11:14:40 Alan Cox wrote:
> On Mon, 1 Jun 2009 11:00:33 +0200
> Michael Buesch <mb@bu3sch.de> wrote:
>
> > This patch fixes array subscription bugs in the parport_pc driver.
> >
> > drivers/parport/parport_pc.c: In function ‘parport_irq_probe’:
> > drivers/parport/parport_pc.c:1589: warning: array subscript is above array bounds
> > drivers/parport/parport_pc.c: In function ‘parport_pc_probe_port’:
> > drivers/parport/parport_pc.c:1579: warning: array subscript is above array bounds
> >
> > The patch also fixes a few other array bugs, which the compiler was
> > unable to find. Coding style violations are also fixed.
>
> Which makes it very hard to see what you are actually changing and
> whether it is a bug. It certainly looks like one but the changes muddled
> in with a random subset of format fixes (even in the area patched only
> some style is fixed)
Yeah well. If I did not fix the style violations, somebody else would have complained
already that when somebody touches some code he should also fix the style issues. ;)
Happened to be several times, so I chose to fix them here...
--
Greetings, Michael.
next prev parent reply other threads:[~2009-06-01 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 9:00 parport_pc: Fix subscription bugs Michael Buesch
2009-06-01 9:14 ` Alan Cox
2009-06-01 9:27 ` Michael Buesch [this message]
2009-06-01 9:58 ` Alan Cox
2009-06-01 10:17 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906011127.03296.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.