All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory Haskins <ghaskins@novell.com>
To: avi@redhat.com
Cc: chrisw@sous-sol.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [KVM PATCH v3 1/3] kvm: fix potential coalesced_mmio leak on shutdown
Date: Mon, 01 Jun 2009 12:54:45 -0400	[thread overview]
Message-ID: <20090601165445.18202.2291.stgit@dev.haskins.net> (raw)
In-Reply-To: <20090601165134.18202.87598.stgit@dev.haskins.net>

It would appear that we are invoking kfree() on the wrong pointer in the
destructor for the coalesced_mmio device.  This could result in a potential
leak during shutdown.  This works today because the kvm_io_device is
the first element of the private structure, but this could change in
the future, so lets clean this up.

Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---

 virt/kvm/coalesced_mmio.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/virt/kvm/coalesced_mmio.c b/virt/kvm/coalesced_mmio.c
index 5ae620d..03ea280 100644
--- a/virt/kvm/coalesced_mmio.c
+++ b/virt/kvm/coalesced_mmio.c
@@ -80,7 +80,10 @@ static void coalesced_mmio_write(struct kvm_io_device *this,
 
 static void coalesced_mmio_destructor(struct kvm_io_device *this)
 {
-	kfree(this);
+	struct kvm_coalesced_mmio_dev *dev =
+		(struct kvm_coalesced_mmio_dev *)this->private;
+
+	kfree(dev);
 }
 
 int kvm_coalesced_mmio_init(struct kvm *kvm)


  reply	other threads:[~2009-06-01 16:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-01 16:54 [KVM PATCH v3 0/3] mmio/pio cleanup Gregory Haskins
2009-06-01 16:54 ` Gregory Haskins [this message]
2009-06-01 17:06   ` [KVM PATCH v3 1/3] kvm: fix potential coalesced_mmio leak on shutdown Chris Wright
2009-06-01 16:54 ` [KVM PATCH v3 2/3] kvm: cleanup io_device code Gregory Haskins
2009-06-01 17:06   ` Chris Wright
2009-06-01 16:54 ` [KVM PATCH v3 3/3] kvm: do not register i8254 PIO regions until we are initialized Gregory Haskins
2009-06-01 17:12   ` Chris Wright
2009-06-02 10:14 ` [KVM PATCH v3 0/3] mmio/pio cleanup Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090601165445.18202.2291.stgit@dev.haskins.net \
    --to=ghaskins@novell.com \
    --cc=avi@redhat.com \
    --cc=chrisw@sous-sol.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.