From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 5/9] cr: capabilities: define checkpoint and restore fns Date: Mon, 1 Jun 2009 17:18:57 -0500 Message-ID: <20090601221857.GA29164@us.ibm.com> References: <20090529223229.GA14536@us.ibm.com> <20090529223319.GE14602@us.ibm.com> <20090601013837.GA15897@hallyn.com> <551280e50905311918j28cd2482g5918bf9b0bcb297a@mail.gmail.com> <20090601133508.GA18889@us.ibm.com> <551280e50906010846i2b46c603x55eea7967233b2e0@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <551280e50906010846i2b46c603x55eea7967233b2e0@mail.gmail.com> Sender: linux-security-module-owner@vger.kernel.org To: "Andrew G. Morgan" Cc: Oren Laadan , Linux Containers , Alexey Dobriyan , David Howells , linux-security-module@vger.kernel.org List-Id: containers.vger.kernel.org Quoting Andrew G. Morgan (morgan@kernel.org): > On Mon, Jun 1, 2009 at 6:35 AM, Serge E. Hallyn wrote: > >> > I'll put in a commented BUILD_BUG_ON like Alexey suggests - does that > >> > suffice? > > I can't speak for other subsystems, but it seems to me as if for the > capabilities, I'd want to create something like this in > include/linux/capabilities.h > > typedef struct checkpoint_caps_s { > /* what goes in here is the capability code's business */ > } checkpoint_caps_t; Sigh - Did a patch this way, but the problem is userspace needs to be able to parse the checkpoint image, so it needs to know what this struct looks like. So if I put it the struct definition include/linux/capability.h, I run into a whole new set of problems trying to compile a userspace program to do a sys_restart(). So I went part-way to what you suggested in the patchset I'm about to send out (please see patch 6/8). I think the caps code does look nicer in this new version. thanks, -serge