All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: add a common removing and unregistering exit function for interfaces when manager_free and manager_destroy function is called
Date: Mon, 01 Jun 2009 22:57:39 -0500	[thread overview]
Message-ID: <200906012257.39773.denkenz@gmail.com> (raw)
In-Reply-To: <61563CE63B4F854986A895DA7AD3C17709D9919BA4@pdsmsx502.ccr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

Hi Minjun,

On Monday 01 June 2009 20:18:23 Li, Minjun wrote:
> Hi Folks,
> Because I found that manager_destroy function is lack of some exit function
> calls comparing to manager_free function, I add a common removing and
> unregistering exit function for interfaces when manager_free and
> manager_destroy function is called.

Please use proper coding style when submitting patches.  This means tabs 
instead of spaces, and proper spacing, e.g. 'if () {'  The functions should be 
named appropriately, 'foo_free' just won't work.

Also, only include patches that are specific to the fix, things like mode change 
are extraneous.   And include a proper commit message.

>
> Best Regards,
> Minjun

Regards,
-Denis

  reply	other threads:[~2009-06-02  3:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02  1:18 add a common removing and unregistering exit function for interfaces when manager_free and manager_destroy function is called Li, Minjun
2009-06-02  3:57 ` Denis Kenzior [this message]
2009-06-03  2:25   ` Xu, Martin
2009-06-03  3:08     ` Li, Minjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906012257.39773.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.