From: Ingo Molnar <mingo@elte.hu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Masami Hiramatsu <mhiramat@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
lkml <linux-kernel@vger.kernel.org>,
systemtap <systemtap@sources.redhat.com>,
kvm <kvm@vger.kernel.org>,
DLE <dle-develop@lists.sourceforge.net>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Roland McGrath <roland@redhat.com>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH -tip v8 5/7] x86: add pt_regs register and stack access APIs
Date: Tue, 2 Jun 2009 01:40:06 +0200 [thread overview]
Message-ID: <20090601234006.GA12629@elte.hu> (raw)
In-Reply-To: <20090530081303.GB15755@infradead.org>
* Christoph Hellwig <hch@infradead.org> wrote:
> > + if (n < NR_REGPARMS) {
> > + switch (n) {
> > + case 0: return regs->ax;
> > + case 1: return regs->dx;
> > + case 2: return regs->cx;
> > + }
>
> Normal kernel style would be
>
> switch (n) {
> case 0:
> return regs->ax;
> case 1:
> return regs->dx;
> case 2:
> return regs->cx;
> }
the original single-line shortcut is acceptable too.
Ingo
next prev parent reply other threads:[~2009-06-01 23:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 0:03 [PATCH -tip v8 0/7] tracing: kprobe-based event tracer and x86 instruction decoder Masami Hiramatsu
2009-05-29 0:03 ` Masami Hiramatsu
2009-05-29 0:03 ` [PATCH -tip v8 1/7] x86: instruction decoder API Masami Hiramatsu
2009-05-29 0:03 ` Masami Hiramatsu
2009-05-29 0:03 ` [PATCH -tip v8 2/7] x86: x86 instruction decoder build-time selftest Masami Hiramatsu
2009-05-29 0:03 ` Masami Hiramatsu
2009-05-29 0:03 ` [PATCH -tip v8 3/7] kprobes: checks probe address is instruction boudary on x86 Masami Hiramatsu
2009-05-29 0:03 ` [PATCH -tip v8 4/7] kprobes: cleanup fix_riprel() using insn decoder " Masami Hiramatsu
2009-05-29 0:03 ` [PATCH -tip v8 5/7] x86: add pt_regs register and stack access APIs Masami Hiramatsu
2009-05-30 8:13 ` Christoph Hellwig
2009-05-30 14:48 ` Masami Hiramatsu
2009-06-01 23:40 ` Ingo Molnar [this message]
2009-05-29 0:03 ` [PATCH -tip v8 6/7] tracing: ftrace dynamic ftrace_event_call support Masami Hiramatsu
2009-05-30 3:23 ` Steven Rostedt
2009-05-29 0:03 ` [PATCH -tip v8 7/7] tracing: add kprobe-based event tracer Masami Hiramatsu
2009-05-29 0:03 ` Masami Hiramatsu
2009-05-30 3:29 ` Steven Rostedt
2009-05-30 4:11 ` Steven Rostedt
2009-05-30 13:15 ` Masami Hiramatsu
2009-05-30 8:15 ` Christoph Hellwig
2009-05-30 14:38 ` Masami Hiramatsu
2009-05-30 8:05 ` [PATCH -tip v8 0/7] tracing: kprobe-based event tracer and x86 instruction decoder Christoph Hellwig
2009-05-31 13:43 ` Masami Hiramatsu
2009-05-31 13:43 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090601234006.GA12629@elte.hu \
--to=mingo@elte.hu \
--cc=ananth@in.ibm.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.